hbase-issues mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "stack (JIRA)" <j...@apache.org>
Subject [jira] [Commented] (HBASE-9031) ImmutableBytesWritable.toString() should downcast the bytes before converting to hex string
Date Sun, 28 Jul 2013 04:41:51 GMT

    [ https://issues.apache.org/jira/browse/HBASE-9031?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13721859#comment-13721859
] 

stack commented on HBASE-9031:
------------------------------

Is there a test that covers this change so we'd know if this patch broke behavior [~adityakishore]?
 Thanks.
                
> ImmutableBytesWritable.toString() should downcast the bytes before converting to hex
string
> -------------------------------------------------------------------------------------------
>
>                 Key: HBASE-9031
>                 URL: https://issues.apache.org/jira/browse/HBASE-9031
>             Project: HBase
>          Issue Type: Bug
>          Components: io
>    Affects Versions: 0.95.1, 0.94.9
>            Reporter: Aditya Kishore
>            Assignee: Aditya Kishore
>            Priority: Minor
>             Fix For: 0.95.2
>
>         Attachments: HBASE-9031.patch, HBASE-9031.patch
>
>
> The attached patch addresses few issues.
> # We need only (3*this.length) capacity in ByteBuffer and not (3*this.bytes.length).
> # Do not calculate (offset + length) at every iteration.
> # No test is required at every iteration to add space (' ') before every byte other than
the first one. Uses {{sb.substring(1)}} instead.
> # Finally and most importantly (the original issue of this report), downcast the promoted
int (the parameter to {{Integer.toHexString()}}) to byte range.
> Without #4, the byte array \{54,125,64, -1, -45\} is transformed to "36 7d 40 ffffffff
ffffffd3" instead of "36 7d 40 ff d3".

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira

Mime
View raw message