hbase-issues mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Hamed Madani (JIRA)" <j...@apache.org>
Subject [jira] [Commented] (HBASE-8947) Thrift 2 : Replace "bool writeToWAL" with "TDurability durability"
Date Tue, 23 Jul 2013 19:18:48 GMT

    [ https://issues.apache.org/jira/browse/HBASE-8947?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13717497#comment-13717497
] 

Hamed Madani commented on HBASE-8947:
-------------------------------------

Thank you [~larsgeorge] for reviewing the patch. 
Since 0.94 uses thrift 0.8.0 and trunk uses thrift 0.9.0 I believe clients updating to 0.95
or above have to re-generate their thrift files anyways. As for numbering thrift fields, I
was under the impression that the fields should be ordered and a missing field number is not
allowed. (i.e can not have 6: optional TDurability durability then 5: optional map<binary,
binary> attributes )
                
> Thrift 2 : Replace "bool writeToWAL" with "TDurability durability" 
> -------------------------------------------------------------------
>
>                 Key: HBASE-8947
>                 URL: https://issues.apache.org/jira/browse/HBASE-8947
>             Project: HBase
>          Issue Type: Sub-task
>          Components: Thrift
>            Reporter: Hamed Madani
>            Assignee: Hamed Madani
>         Attachments: HBASE-8947.patch, HBASE-8947-v2.patch, HBASE-8947-v3-0.94.patch,
HBASE-8947-v3.patch
>
>
> Introduce new enum *TDurability* to expose more options for *Write To Wal.* 

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira

Mime
View raw message