hbase-issues mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Hamed Madani (JIRA)" <j...@apache.org>
Subject [jira] [Commented] (HBASE-8947) Thrift 2 : Replace "bool writeToWAL" with "TDurability durability"
Date Mon, 22 Jul 2013 08:12:48 GMT

    [ https://issues.apache.org/jira/browse/HBASE-8947?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13715001#comment-13715001
] 

Hamed Madani commented on HBASE-8947:
-------------------------------------

For 0.94 we can drop the default for writeToWAL to avoid sending an extra field. I just double
checked and for 0.94 
{code}
  private boolean writeToWAL = true;
{code}
writeToWAL get initialized to true , so I suggest we drop default value for writeToWAL, add
Durability to Mutation (Apparently Increment doesn't support it since it doesn't extend Mutation
in 0.94), then as you suggested we check for isSetDurability, if not set then isSetwriteToWAL
and if not set then just don't set writeToWAL since it gets initialized to true inside Mutation
class. What do you think ? Also do we need a test for this ? I wasn't sure how to test it.
 
                
> Thrift 2 : Replace "bool writeToWAL" with "TDurability durability" 
> -------------------------------------------------------------------
>
>                 Key: HBASE-8947
>                 URL: https://issues.apache.org/jira/browse/HBASE-8947
>             Project: HBase
>          Issue Type: Sub-task
>          Components: Thrift
>            Reporter: Hamed Madani
>            Assignee: Hamed Madani
>         Attachments: HBASE-8947.patch, HBASE-8947-v2.patch
>
>
> Introduce new enum *TDurability* to expose more options for *Write To Wal.* 

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira

Mime
View raw message