hbase-issues mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Lars George (JIRA)" <j...@apache.org>
Subject [jira] [Commented] (HBASE-8946) Add a new function to Thrift 2 to open scanner, get results and close scanner
Date Sat, 20 Jul 2013 11:24:49 GMT

    [ https://issues.apache.org/jira/browse/HBASE-8946?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13714405#comment-13714405
] 

Lars George commented on HBASE-8946:
------------------------------------

Wait...

bq. * Exhausted scanners are closed automatically.

This actually relates to HBASE-8852. Come to think of it, it seems to be a good idea to reopen
the discussion on this. I mean, if we were to close and release the scanners when they exhausted,
it would save an additional RPC call. But then what about loops where you do not know you
are at the end? I think what we have now, with your addition, and the true open + get + close
calls we should be good. If we then add HBASE-3852 to take care of those where the user choses
path C, i.e. open + get but without a close, we should be good. Any opinions?
                
> Add a new function to Thrift 2 to open scanner, get results and close scanner
> -----------------------------------------------------------------------------
>
>                 Key: HBASE-8946
>                 URL: https://issues.apache.org/jira/browse/HBASE-8946
>             Project: HBase
>          Issue Type: Sub-task
>          Components: Thrift
>            Reporter: Hamed Madani
>              Labels: thrift2
>         Attachments: HBASE-8946.patch, HBASE-8946-V2.patch, HBASE-8946-V3.patch
>
>
> We found, very often we open a scanner , get x number of rows , then close the scanner
immediately. The attached patch , add a new function *getScannerResults* that does just that.

> Using getScannerResults function reduce number of calls to thrift server. Also since
the scanner gets closed immediately, it is less prone to cause memory leak. 

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira

Mime
View raw message