hbase-issues mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Lars George (JIRA)" <j...@apache.org>
Subject [jira] [Commented] (HBASE-8946) Add a new function to Thrift 2 to open scanner, get results and close scanner
Date Fri, 19 Jul 2013 21:12:48 GMT

    [ https://issues.apache.org/jira/browse/HBASE-8946?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13714078#comment-13714078
] 

Lars George commented on HBASE-8946:
------------------------------------

Sorry, my bad (too late for me here) :)

One nit, could you extend the test to scan three times, with 5, 10, and 20 rows? Just to check
they return 5, 10 and 10 as expected per the test rows?

Also, for some reason the patch does not apply to 0.95, there seems to be a class that is
different to trunk. Would you be able to have a look too?
                
> Add a new function to Thrift 2 to open scanner, get results and close scanner
> -----------------------------------------------------------------------------
>
>                 Key: HBASE-8946
>                 URL: https://issues.apache.org/jira/browse/HBASE-8946
>             Project: HBase
>          Issue Type: Sub-task
>          Components: Thrift
>            Reporter: Hamed Madani
>              Labels: thrift2
>         Attachments: HBASE-8946.patch, HBASE-8946-V2.patch
>
>
> We found, very often we open a scanner , get x number of rows , then close the scanner
immediately. The attached patch , add a new function *getScannerResults* that does just that.

> Using getScannerResults function reduce number of calls to thrift server. Also since
the scanner gets closed immediately, it is less prone to cause memory leak. 

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira

Mime
View raw message