hbase-issues mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Lars George (JIRA)" <j...@apache.org>
Subject [jira] [Commented] (HBASE-8943) Split Thrift2's ThriftServer into separate classes for easier testing and modularization
Date Mon, 15 Jul 2013 09:42:49 GMT

    [ https://issues.apache.org/jira/browse/HBASE-8943?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13708347#comment-13708347
] 

Lars George commented on HBASE-8943:
------------------------------------

Just to clarify my above comment on REST - it seems that if we would have had someone in the
past to drive Thrift, we would not be in this dual interface predicament. REST had an owner
and got in timely and swiftly. Thrift should have been the same. No one to blame, just saying.
                
> Split Thrift2's ThriftServer into separate classes for easier testing and modularization
> ----------------------------------------------------------------------------------------
>
>                 Key: HBASE-8943
>                 URL: https://issues.apache.org/jira/browse/HBASE-8943
>             Project: HBase
>          Issue Type: Sub-task
>          Components: Thrift
>            Reporter: Lars George
>            Assignee: Lars George
>              Labels: thrift2
>
> Currently the ThriftServer class in Thrift 2 sets up and starts the actual server. Better
follow a similar pattern to Thrift 1 where there is some factory setting up the server, and
a separate start section. That way it is easier to test if the setup of the server is picking
up everything it needs.

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira

Mime
View raw message