hbase-issues mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "stack (JIRA)" <j...@apache.org>
Subject [jira] [Commented] (HBASE-8899) Could not open a region on a server where it is being closed
Date Tue, 09 Jul 2013 00:31:48 GMT

    [ https://issues.apache.org/jira/browse/HBASE-8899?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13702684#comment-13702684

stack commented on HBASE-8899:

+1 on commit.  You might address below on commit?

Add comment here because it is opaque that FALSE in this map means an ongoing close.

-            LOG.warn("Attempted open of " + region.getEncodedName()
+            Boolean closing = regionsInTransitionInRS.get(region.getEncodedNameAsBytes());

Why not just do if (!closing)? (Let autoboxing provide the rest? Maybe it don't work)

+            if (!Boolean.FALSE.equals(closing)) { // Only return ALREADY_OPENED if not closing
> Could not open a region on a server where it is being closed
> ------------------------------------------------------------
>                 Key: HBASE-8899
>                 URL: https://issues.apache.org/jira/browse/HBASE-8899
>             Project: HBase
>          Issue Type: Bug
>          Components: Region Assignment
>            Reporter: Jimmy Xiang
>            Assignee: Jimmy Xiang
>            Priority: Minor
>         Attachments: trunk-8899.patch
> Looked into the failure of an AM none-flaky test:
> The test failed to open a region on a server where the region was being closed.  Region
server just returned ALREADY_OPENED while the region was actually being closed.

This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira

View raw message