hbase-issues mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Sergey Shelukhin (JIRA)" <j...@apache.org>
Subject [jira] [Commented] (HBASE-8893) Verify that HTableDescriptor Properties are preserved when cloning
Date Mon, 08 Jul 2013 18:41:54 GMT

    [ https://issues.apache.org/jira/browse/HBASE-8893?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13702261#comment-13702261
] 

Sergey Shelukhin commented on HBASE-8893:
-----------------------------------------

{code}
+    Assert.assertTrue(cloneHtd.getValues().size() > 0);
+    Assert.assertTrue(cloneHtd.getConfiguration().size() > 0);
+    Assert.assertEquals(originalTableDescriptor.getValues().size(),
+                        cloneHtd.getValues().size());
+    Assert.assertEquals(originalTableDescriptor.getConfiguration().size(),
+                        cloneHtd.getConfiguration().size());
{code}
The former asserts are redundant.

+1 otherwise
                
> Verify that HTableDescriptor Properties are preserved when cloning
> ------------------------------------------------------------------
>
>                 Key: HBASE-8893
>                 URL: https://issues.apache.org/jira/browse/HBASE-8893
>             Project: HBase
>          Issue Type: Bug
>          Components: snapshots, test
>            Reporter: Matteo Bertozzi
>            Assignee: Matteo Bertozzi
>            Priority: Trivial
>             Fix For: 0.95.2
>
>         Attachments: HBASE-8893-v0.patch
>
>
> the current SnapshotMetadata test covers only the column families of the descriptor.
Extend it to verify also the extra "values" and "configuration" fields

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira

Mime
View raw message