hbase-issues mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Jean-Daniel Cryans (JIRA)" <j...@apache.org>
Subject [jira] [Commented] (HBASE-8888) Tweak retry settings some more, *some more*
Date Mon, 08 Jul 2013 17:03:49 GMT

    [ https://issues.apache.org/jira/browse/HBASE-8888?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13702123#comment-13702123
] 

Jean-Daniel Cryans commented on HBASE-8888:
-------------------------------------------

Woah that's a fat patch! Looks like a good cleanup tho. Nits:

bq. +  private static final Log LOG = LogFactory.getLog("RetryAccountant");

How do we know who this belongs to? Who is retrying?

bq. +      LOG.info("Sleeping " + sleepTime + "ms after retry #" + getAttempt() + "...");

Add a blank space in the string before ms.


                
> Tweak retry settings some more, *some more*
> -------------------------------------------
>
>                 Key: HBASE-8888
>                 URL: https://issues.apache.org/jira/browse/HBASE-8888
>             Project: HBase
>          Issue Type: Bug
>            Reporter: stack
>            Assignee: stack
>             Fix For: 0.95.2
>
>         Attachments: 8888.txt
>
>
> Follow on from hbase-8776.
> Need to fix retries and timeouts.  We cut them down so much hbase-it tests fail.
> From https://issues.apache.org/jira/browse/HBASE-8776?focusedCommentId=13698762&page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel#comment-13698762
@nkeywal says:
> {code}
> I would like to change
> hbase.client.retries.number -> 30 (instead of 14 or 20 today)
> hbase.client.pause -> 500 (instead of 100 or 1000 today).
> Context: see HBASE-6295.
> As well, would it make sense to remove all the hbase-site.xml and hbase-defaults.xml
to rely only on the defaults in the code. This would trigger another set of issues, as sometimes
the defaults are duplicated and different. But these are bugs as well. Imho, this duplication
is confusing and it leads to unreliable behavior as we don't really know what are the setting
actually used.
> {code}
> Regards removing hbase-site.xml from everywhere to rely on defaults in code, over in
hbase-8776 I tried removing them and way too many tests failed.  Looks like it'd be tough
removing them.

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira

Mime
View raw message