hbase-issues mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Liang Xie (JIRA)" <j...@apache.org>
Subject [jira] [Updated] (HBASE-8870) Store.needsCompaction() should include minFilesToCompact
Date Thu, 04 Jul 2013 12:47:48 GMT

     [ https://issues.apache.org/jira/browse/HBASE-8870?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]

Liang Xie updated HBASE-8870:
-----------------------------

    Description: 
I read here:
{code}
  public boolean needsCompaction() {
    return (storefiles.size() - filesCompacting.size()) > minFilesToCompact;
  }
{code}

imho, it should be 

{code}
  public boolean needsCompaction() {
    return (storefiles.size() - filesCompacting.size()) >= minFilesToCompact;
  }
{code}
    
> Store.needsCompaction() should include minFilesToCompact
> --------------------------------------------------------
>
>                 Key: HBASE-8870
>                 URL: https://issues.apache.org/jira/browse/HBASE-8870
>             Project: HBase
>          Issue Type: Bug
>          Components: Compaction
>            Reporter: Liang Xie
>            Assignee: Liang Xie
>            Priority: Minor
>
> I read here:
> {code}
>   public boolean needsCompaction() {
>     return (storefiles.size() - filesCompacting.size()) > minFilesToCompact;
>   }
> {code}
> imho, it should be 
> {code}
>   public boolean needsCompaction() {
>     return (storefiles.size() - filesCompacting.size()) >= minFilesToCompact;
>   }
> {code}

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira

Mime
View raw message