hbase-issues mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Sergey Shelukhin (JIRA)" <j...@apache.org>
Subject [jira] [Commented] (HBASE-8870) Store.needsCompaction() should include minFilesToCompact
Date Tue, 09 Jul 2013 18:27:48 GMT

    [ https://issues.apache.org/jira/browse/HBASE-8870?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13703596#comment-13703596
] 

Sergey Shelukhin commented on HBASE-8870:
-----------------------------------------

this test also fails for me with this patch... probably makes some assumptions about when
compactions happen
                
> Store.needsCompaction() should include minFilesToCompact
> --------------------------------------------------------
>
>                 Key: HBASE-8870
>                 URL: https://issues.apache.org/jira/browse/HBASE-8870
>             Project: HBase
>          Issue Type: Bug
>          Components: Compaction
>    Affects Versions: 0.95.1
>            Reporter: Liang Xie
>            Assignee: Liang Xie
>            Priority: Minor
>         Attachments: HBASE-8870.txt, HBASE-8870.txt
>
>
> read here:
> {code}
>   public boolean needsCompaction() {
>     return (storefiles.size() - filesCompacting.size()) > minFilesToCompact;
>   }
> {code}
> imho, it should be 
> {code}
>   public boolean needsCompaction() {
>     return (storefiles.size() - filesCompacting.size()) >= minFilesToCompact;
>   }
> {code}

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira

Mime
View raw message