hbase-issues mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "stack (JIRA)" <j...@apache.org>
Subject [jira] [Commented] (HBASE-8810) Bring in code constants in line with default xml's
Date Thu, 04 Jul 2013 03:54:22 GMT

    [ https://issues.apache.org/jira/browse/HBASE-8810?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13699743#comment-13699743
] 

stack commented on HBASE-8810:
------------------------------

The hbase-default.xml is hard to get rid of.  While it is a pain to update it and code, hbase-default.xml
is used to publish those configs. we think operators should be concerned with, it is used
to generate documentation (the descriptions are in the xml file and no where else), and we
sometimes make use of the interpolation feature which substitutes variables w/ environment
defines: e.g. user or tmp.dir.

So, styling hbase-default.xml to produce a constants file to include would be a bunch of work,
too much work.

1. I'd have to add type attributes to hbase-default.xml and then in stylesheet dependent on
whether string, boolean, int or long, format the value appropriately (bunch of ugly xsl).
2. Change build to generate then include this new file.
3. Go through code and change all hbase-default.xml properties to instead get their values
out of this constants file.
4. Put in place docs and some constraint so adding a value to hbase-default.xml, you somehow
would get it all right.

Let me see if can generate unit test from hbase-default.xml.  Will have same typing issue
though....
                
> Bring in code constants in line with default xml's
> --------------------------------------------------
>
>                 Key: HBASE-8810
>                 URL: https://issues.apache.org/jira/browse/HBASE-8810
>             Project: HBase
>          Issue Type: Bug
>          Components: Usability
>            Reporter: Elliott Clark
>            Assignee: Elliott Clark
>             Fix For: 0.95.2
>
>         Attachments: hbase-default_to_java_constants.xsl, HBaseDefaultXMLConstants.java
>
>
> After the defaults were changed in the xml some constants were left the same.
> DEFAULT_HBASE_CLIENT_PAUSE for example.

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira

Mime
View raw message