hbase-issues mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "stack (JIRA)" <j...@apache.org>
Subject [jira] [Commented] (HBASE-8810) Bring in code constants in line with default xml's
Date Thu, 04 Jul 2013 16:45:50 GMT

    [ https://issues.apache.org/jira/browse/HBASE-8810?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13700199#comment-13700199

stack commented on HBASE-8810:

[~nkeywal] I'd have to do the interpolations in code:


... which is then used later in stuff like:


Won't we have typing issue if we go your approach too?

file.get returns a String.

code.getField returns an Object (could be a String, could be long, etc.)

Since types are not same, overloading will not be able to discern the right assertEquals

I'm fine hand-coding this all up but would like to avoid having to do update in two places.

Could we mark public configs w/ annotation and generate the xml for inclusion in doc?  (There
would still be the interpolation issue -- though I suppose this ain't the end of the world;
we could just do system properties).
> Bring in code constants in line with default xml's
> --------------------------------------------------
>                 Key: HBASE-8810
>                 URL: https://issues.apache.org/jira/browse/HBASE-8810
>             Project: HBase
>          Issue Type: Bug
>          Components: Usability
>            Reporter: Elliott Clark
>            Assignee: Elliott Clark
>             Fix For: 0.95.2
>         Attachments: 8810.txt, 8810v2.txt, hbase-default_to_java_constants.xsl, HBaseDefaultXMLConstants.java
> After the defaults were changed in the xml some constants were left the same.

This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira

View raw message