hbase-issues mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "stack (JIRA)" <j...@apache.org>
Subject [jira] [Commented] (HBASE-8797) Prevent merging regions from moving during online merge
Date Tue, 02 Jul 2013 05:06:21 GMT

    [ https://issues.apache.org/jira/browse/HBASE-8797?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13697508#comment-13697508
] 

stack commented on HBASE-8797:
------------------------------

Nothing to do when you get this Jimmy?

{code}
+          LOG.info("Processed region " + regionInfo.getEncodedName()
+              + " in state : " + et + " nothing to do.");
+        }
{code}

Just pass through?

Should this RS_ZK_REGION_MERGE be called RS_ZK_REGION_MERGED ?

In isInStateForMerging, you are testing isOpenOrMergingOnServer.  That seems a little loose?
 Should it just be testing isMergingOnServer only?

So, if RS crashes after putting up two MERGING znodes, they are ephemeral (are they?) and
they will just evaporate?  When the logs for crashed server are played, we will just presume
the merge did not succeed?  And will assign out the two regions that were merging?  Is there
a hole in here where the merge succeeded but master was not notified yet?  In this case will
we find the merged region and assign it out?

If we get the merge message and then that the RS has crashed, ofter WAL split, we'll assign
out the merged region .. and not the two daughter inputs?

Patch looks good Jimmy.
                
> Prevent merging regions from moving during online merge
> -------------------------------------------------------
>
>                 Key: HBASE-8797
>                 URL: https://issues.apache.org/jira/browse/HBASE-8797
>             Project: HBase
>          Issue Type: Bug
>          Components: regionserver
>            Reporter: Jimmy Xiang
>            Assignee: Jimmy Xiang
>         Attachments: trunk-8797.patch
>
>
> When two regions are merged online, they are closed but master doesn't know they should
stay closed during the merge.  If master moves them by mistake, for example, load balancer
kicks in, the merge could be messed up.

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira

Mime
View raw message