hbase-issues mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Hamed Madani (JIRA)" <j...@apache.org>
Subject [jira] [Commented] (HBASE-8779) add mutateRow method support to thrift2
Date Wed, 17 Jul 2013 08:36:50 GMT

    [ https://issues.apache.org/jira/browse/HBASE-8779?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13710862#comment-13710862
] 

Hamed Madani commented on HBASE-8779:
-------------------------------------

[~larsgeorge] I moved this under the umbrella issue for Thrift 2.
I did review the patch. *mutateRow* never returns htable to pool. Also uses the old table.array().

Also I think it will be a better idea to follow thrift 1 for mutation struct. the patch suggest
to use : 

{code}
struct TMutation {
  1: optional TPut put,
  2: optional TDelete deleteSingle
}
{code}

However I suggest the below struct for TMutation which follows thrift 1 implementation more
closely and I believe is more convenient and efficient. 

{code}
 struct TMutation {
  1: required TColumn column,
  2: optional binary value,
  3: optional bool isDelete = 0,
  4: optional TDeleteType deleteType = 1,
  5: optional TDurability durability,
  6: optional map<binary, binary> attributes
}

struct TRowMutations {
  1: required binary row
  2: required List<Mutation> mutations
}
{code}

                
> add mutateRow method support to thrift2
> ---------------------------------------
>
>                 Key: HBASE-8779
>                 URL: https://issues.apache.org/jira/browse/HBASE-8779
>             Project: HBase
>          Issue Type: Sub-task
>          Components: Thrift
>            Reporter: duanhongyi
>             Fix For: 0.94.11
>
>         Attachments: 0.94.patch
>
>
> examples py:
> TPut put = TPut()
> m1 = TMutation(put=put)
> TDelete single_delete = TDelete()
> m2 = TMutation(singleDelete=single_delete)
> row_mu = TRowMutations(row,[m1,m2])
> thbase_service.mutateRow(table,row_mu)  # atomically on a single row

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira

Mime
View raw message