hbase-issues mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Jean-Daniel Cryans (JIRA)" <j...@apache.org>
Subject [jira] [Updated] (HBASE-8732) HFileBlockDefaultEncodingContext isn't thread-safe but is used by all readers, breaks column encoding
Date Wed, 17 Jul 2013 18:15:52 GMT

     [ https://issues.apache.org/jira/browse/HBASE-8732?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]

Jean-Daniel Cryans updated HBASE-8732:
--------------------------------------

    Attachment: HBASE-8732.patch

Attaching a patch that fixes the problem by re-creating the HFileBlockDefaultEncodingContext
each time a block is read from disk. If there's any performance impact here it would be restricted
to those using in-cache encoding only (which is not the default) or those that just enabled
encoding and still have files that aren't encoded.

I tried the patch manually with a PE randomRead 10 (fails without this), the integration test
in HBASE-8726 passes now, and I ran all the unit tests that match Test*Encod*.
                
> HFileBlockDefaultEncodingContext isn't thread-safe but is used by all readers, breaks
column encoding
> -----------------------------------------------------------------------------------------------------
>
>                 Key: HBASE-8732
>                 URL: https://issues.apache.org/jira/browse/HBASE-8732
>             Project: HBase
>          Issue Type: Bug
>          Components: regionserver
>    Affects Versions: 0.98.0, 0.95.1
>            Reporter: Elliott Clark
>            Assignee: Jean-Daniel Cryans
>            Priority: Critical
>             Fix For: 0.98.0, 0.95.2
>
>         Attachments: HBASE-8732.patch
>
>
> Getting an error when opening a scanner on a file that has no encoding.

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira

Mime
View raw message