hbase-issues mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "stack (JIRA)" <j...@apache.org>
Subject [jira] [Commented] (HBASE-8699) Parameter to DistributedFileSystem#isFileClosed should be of type Path
Date Mon, 08 Jul 2013 22:43:49 GMT

    [ https://issues.apache.org/jira/browse/HBASE-8699?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13702552#comment-13702552
] 

stack commented on HBASE-8699:
------------------------------

[~ted_yu] So, your test is for 1.2.0 and 2.1.0 only?  If we run against 1.2.1, the test is
not triggered?  If so, that is just silly.
                
> Parameter to DistributedFileSystem#isFileClosed should be of type Path
> ----------------------------------------------------------------------
>
>                 Key: HBASE-8699
>                 URL: https://issues.apache.org/jira/browse/HBASE-8699
>             Project: HBase
>          Issue Type: Bug
>          Components: wal
>            Reporter: Ted Yu
>            Assignee: Ted Yu
>         Attachments: 8699-v1.txt, 8699-v3.txt
>
>
> Here is current code of FSHDFSUtils#isFileClosed():
> {code}
>   boolean isFileClosed(final DistributedFileSystem dfs, final Path p) {
>     try {
>       Method m = dfs.getClass().getMethod("isFileClosed", new Class<?>[] {String.class});
>       return (Boolean) m.invoke(dfs, p.toString());
> {code}
> We look for isFileClosed method with parameter type of String.
> However, from hadoop-hdfs-project/hadoop-hdfs/src/main/java/org/apache/hadoop/hdfs/DistributedFileSystem.java
(branch-2):
> {code}
>   public boolean isFileClosed(Path src) throws IOException {
> {code}
> The parameter type is of Path.
> This means we would get NoSuchMethodException.

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira

Mime
View raw message