hbase-issues mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "chunhui shen (JIRA)" <j...@apache.org>
Subject [jira] [Commented] (HBASE-8648) Call to equals() comparing different types in HRegionServer.handleReportForDutyResponse()
Date Sun, 14 Jul 2013 01:42:48 GMT

    [ https://issues.apache.org/jira/browse/HBASE-8648?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13707914#comment-13707914
] 

chunhui shen commented on HBASE-8648:
-------------------------------------

{code}
this.serverNameFromMasterPOV = new ServerName(hostnameFromMasterPOV,
            this.isa.getPort(), this.startcode);
-          if (!hostnameFromMasterPOV.equals(this.isa.getHostName())) {
+          if (!this.serverNameFromMasterPOV.getHostname()
+              .equals(this.isa.getHostName())) {

{code}
>From the patch,  the description code {code}
if (!this.serverNameFromMasterPOV.equals(this.isa.getHostName())) {
{code} 
seems not matched where the fact code is {code}if (!hostnameFromMasterPOV.equals(this.isa.getHostName()))
{
{code}
                
> Call to equals() comparing different types in HRegionServer.handleReportForDutyResponse()
> -----------------------------------------------------------------------------------------
>
>                 Key: HBASE-8648
>                 URL: https://issues.apache.org/jira/browse/HBASE-8648
>             Project: HBase
>          Issue Type: Bug
>            Reporter: Ted Yu
>            Assignee: Ted Yu
>            Priority: Minor
>         Attachments: 8648-v1.txt, 8648-v2.txt
>
>
> Here is related code:
> {code}
>           if (!this.serverNameFromMasterPOV.equals(this.isa.getHostName())) {
> {code}
> serverNameFromMasterPOV is of type ServerName but this.isa.getHostName() returns String

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira

Mime
View raw message