hbase-issues mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Anoop Sam John (JIRA)" <j...@apache.org>
Subject [jira] [Commented] (HBASE-8496) Implement tags and the internals of how a tag should look like
Date Fri, 26 Jul 2013 06:23:48 GMT

    [ https://issues.apache.org/jira/browse/HBASE-8496?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13720452#comment-13720452
] 

Anoop Sam John commented on HBASE-8496:
---------------------------------------

bq.Why does EncodedScannerV3 need to keep reference to HFileReaderV3 ?
Using a field includesTag and to avoid the type casting, kept a reference this way
{code}
dataBlockEncoder.createSeeker(reader.getComparator(),
+          includesMemstoreTS, this.reader.includesTag);
{code}
bq.Please remove the trailing ^M.
Sure. Sorry 

bq.Although there is code duplication with HFileWriterV2, I think it is fine for first cut.
Ya tried to avoid many. Still possible to avoid some more duplication with refactoring.

Thanks Ted

                
> Implement tags and the internals of how a tag should look like
> --------------------------------------------------------------
>
>                 Key: HBASE-8496
>                 URL: https://issues.apache.org/jira/browse/HBASE-8496
>             Project: HBase
>          Issue Type: New Feature
>            Reporter: ramkrishna.s.vasudevan
>            Assignee: ramkrishna.s.vasudevan
>             Fix For: 0.98.0
>
>         Attachments: Comparison.pdf, HBASE-8496.patch, Tag design.pdf
>
>
> The intent of this JIRA comes from HBASE-7897.
> This would help us to decide on the structure and format of how the tags should look
like. 

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira

Mime
View raw message