hbase-issues mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Ted Yu (JIRA)" <j...@apache.org>
Subject [jira] [Commented] (HBASE-8496) Implement tags and the internals of how a tag should look like
Date Fri, 26 Jul 2013 05:27:48 GMT

    [ https://issues.apache.org/jira/browse/HBASE-8496?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13720420#comment-13720420
] 

Ted Yu commented on HBASE-8496:
-------------------------------

Browsed through HFileWriterV3 which needs class javadoc.
Although there is code duplication with HFileWriterV2, I think it is fine for first cut.

HFileReaderV3 needs license and class javadoc.
{code}
+  protected static class EncodedScannerV3 extends EncodedScannerV2 {^M
+    private DataBlockEncoder.EncodedSeeker seeker = null;^M
+    private HFileReaderV3 reader;^M
{code}
Why does EncodedScannerV3 need to keep reference to HFileReaderV3 ? AbstractHFileReader#Scanner#getReader()
would return the reader, right ?

Can you upload patch onto review board ? Please remove the trailing ^M.
                
> Implement tags and the internals of how a tag should look like
> --------------------------------------------------------------
>
>                 Key: HBASE-8496
>                 URL: https://issues.apache.org/jira/browse/HBASE-8496
>             Project: HBase
>          Issue Type: New Feature
>            Reporter: ramkrishna.s.vasudevan
>            Assignee: ramkrishna.s.vasudevan
>             Fix For: 0.98.0
>
>         Attachments: Comparison.pdf, HBASE-8496.patch, Tag design.pdf
>
>
> The intent of this JIRA comes from HBASE-7897.
> This would help us to decide on the structure and format of how the tags should look
like. 

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira

Mime
View raw message