hbase-issues mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Himanshu Vashishtha (JIRA)" <j...@apache.org>
Subject [jira] [Commented] (HBASE-8348) Polish the migration to 0.96
Date Tue, 30 Jul 2013 05:57:51 GMT

    [ https://issues.apache.org/jira/browse/HBASE-8348?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13723440#comment-13723440
] 

Himanshu Vashishtha commented on HBASE-8348:
--------------------------------------------

{code}
 +    try {
+      region = HRegion.openHRegion(HRegionInfo.ROOT_REGIONINFO,
+          HTableDescriptor.ROOT_TABLEDESC, null, getConf());
+      Scan s = new Scan();
{code}
ROOT? Or you mean FIRST_META_REGIONINFO?
{code}
bq. +        } else if (child.equals(conf.get("zookeeper.znode.tableEnableDisable",
+            "table"))
+            || child.equals(conf.get(
+                "zookeeper.znode.masterTableEnableDisable", "table"))) {
+          checkAndMigrateTableStatesToPB(zkw);
{code}
Why are we doing this?

I wonder the utility of migrating the existing znodes / or creating meta server znodes while
doing the migration to 0.95.
Why not let HBase create them out of the box? What if we fail in the middle of this znode
upgrade? What

                
> Polish the migration to 0.96
> ----------------------------
>
>                 Key: HBASE-8348
>                 URL: https://issues.apache.org/jira/browse/HBASE-8348
>             Project: HBase
>          Issue Type: Bug
>    Affects Versions: 0.95.0
>            Reporter: Jean-Daniel Cryans
>            Assignee: rajeshbabu
>            Priority: Critical
>             Fix For: 0.95.2
>
>         Attachments: HBASE-8348_trunk.patch, HBASE-8348_trunk_v2.patch
>
>
> Currently, migration works but there's still a couple of rough edges:
>  - HBASE-8045 finished the .META. migration but didn't remove ROOT, so it's still on
the filesystem.
>  - Data in ZK needs to be removed manually. Either we fix up the data in ZK or we delete
it ourselves.
>  - TestMetaMigrationRemovingHTD has a testMetaUpdatedFlagInROOT method, but ROOT is gone
now.
> Elliott was also mentioning that we could have "hbase migrate" do the HFileV1 checks,
clear ZK, remove ROOT, etc.

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira

Mime
View raw message