hbase-issues mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Jean-Daniel Cryans (JIRA)" <j...@apache.org>
Subject [jira] [Commented] (HBASE-8329) Limit compaction speed
Date Tue, 09 Jul 2013 21:19:51 GMT

    [ https://issues.apache.org/jira/browse/HBASE-8329?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13703807#comment-13703807
] 

Jean-Daniel Cryans commented on HBASE-8329:
-------------------------------------------

I think this jira is not ready for inclusion, stuff like this should not make it into the
code:

{code}
+  /**
+   * @return whether this is peak hour
+   */
+  private boolean isPeakHour() {
+    return offPeakHours.isOffPeakHour();
+  }
{code}

Also OffPeakHours now has two {{getInstance()}} that are very, very similar. It needs to be
refactored.

This needs to be fixed:

{code}
+ * The class used to track peak hours and compactions. peak compaction speed
+ * should be limit.
{code}

Those configurations should have the same prefix since we know it's related to compactions:

{code}
+  public static final String PEAK_START_HOUR = "hbase.peak.start.hour";
+  public static final String PEAK_END_HOUR = "hbase.peak.end.hour";
+  public static final String PEAK_COMPACTION_SPEED_ALLOWED =
+      "hbase.regionserver.compaction.peak.maxspeed";
+  public static final String PEAK_COMPACTION_SPEED_CHECK_INTERVAL =
+      "hbase.regionserver.compaction.speed.check.interval";
{code}

And what is the value of this at INFO level?

{code}
+      LOG.info("Region '" + region + "' family '" + family + "' 's maxSpeedInPeak is "
+          + StringUtils.humanReadableInt(maxSpeedInPeak) + "/s compaction throttle: sleep
number  "
+          + sleepNumber + " sleep time " + sleepTimeTotal + "(ms)");
{code}

Was is the reasoning behind limiting the speed to 30MB/s? Should we document this in the code?
                
> Limit compaction speed
> ----------------------
>
>                 Key: HBASE-8329
>                 URL: https://issues.apache.org/jira/browse/HBASE-8329
>             Project: HBase
>          Issue Type: Improvement
>          Components: Compaction
>            Reporter: binlijin
>            Assignee: binlijin
>             Fix For: 0.95.2
>
>         Attachments: HBASE-8329-2-trunk.patch, HBASE-8329-3-trunk.patch, HBASE-8329-4-trunk.patch,
HBASE-8329-5-trunk.patch, HBASE-8329-trunk.patch
>
>
> There is no speed or resource limit for compaction´╝îI think we should add this feature
especially when request burst.

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira

Mime
View raw message