hbase-issues mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Hudson (JIRA)" <j...@apache.org>
Subject [jira] [Commented] (HBASE-8012) Reseek should position to the beginning of file for the first time it is invoked with a KV smaller than the first KV in file
Date Tue, 02 Jul 2013 16:07:20 GMT

    [ https://issues.apache.org/jira/browse/HBASE-8012?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13697913#comment-13697913
] 

Hudson commented on HBASE-8012:
-------------------------------

Integrated in HBase-0.94-security #187 (See [https://builds.apache.org/job/HBase-0.94-security/187/])
    HBASE-8767 Backport hbase-8001 and hbase-8012, avoid lazy seek (original patches by Raymond
Liu) (Revision 1498953)

     Result = SUCCESS
                
> Reseek should position to the beginning of file for the first time it is invoked with
a KV smaller than the first KV in file
> ----------------------------------------------------------------------------------------------------------------------------
>
>                 Key: HBASE-8012
>                 URL: https://issues.apache.org/jira/browse/HBASE-8012
>             Project: HBase
>          Issue Type: Bug
>          Components: regionserver
>    Affects Versions: 0.94.5
>            Reporter: Raymond Liu
>            Assignee: Raymond Liu
>            Priority: Minor
>             Fix For: 0.98.0, 0.95.0
>
>         Attachments: HBASE-8012.patch, HBASE-8012.patch, HBASE-8012_v2.patch
>
>
> The storeFileScanner's seekAtOrAfter method will position at the beginning of the file
when the passed KV is smaller than first KV in file. While for reseekAtOrAfter, I think it
should also do the same thing when it is the first time it been seeked. originally, this is
workaround by adding a isReseekable property in StoreFileScanner, and is checked upon each
enforceSeek(), if it is not seeked before, it will go with seek approaching instead of reseek
approaching. While why not make reseekAtOrAfter working correctly for the first time it been
reseek (also never been seek before), since the file is never seeked before, so position it
at the beginning of the file don't break the idea of "reseek", say never rewind.
> It will save the effort for HBASE-8001, with this fixed, it won't need to check isReseekable
any more.

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira

Mime
View raw message