hbase-issues mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Jean-Daniel Cryans (JIRA)" <j...@apache.org>
Subject [jira] [Commented] (HBASE-7826) Improve Hbase Thrift v1 to return results in sorted order
Date Mon, 08 Jul 2013 23:39:49 GMT

    [ https://issues.apache.org/jira/browse/HBASE-7826?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13702629#comment-13702629
] 

Jean-Daniel Cryans commented on HBASE-7826:
-------------------------------------------

Please add a space after your commas on lines like:

bq. +          return ThriftUtilities.rowResultFromHBase(result,false);

ResultScannerWrapper's attribute should be final. {{columns}} should have a more descriptive
name. Its getter should start with "is" not "get".

In ThriftUtilities the indentation is off and we use only 2 spaces.

ThriftUtilities.rowResultFromHBase should have more javadoc about the new parameter.

Thanks Shivendra.
                
> Improve Hbase Thrift v1 to return results in sorted order
> ---------------------------------------------------------
>
>                 Key: HBASE-7826
>                 URL: https://issues.apache.org/jira/browse/HBASE-7826
>             Project: HBase
>          Issue Type: New Feature
>          Components: Thrift
>    Affects Versions: 0.94.0
>            Reporter: Shivendra Pratap Singh
>            Assignee: Shivendra Pratap Singh
>            Priority: Minor
>              Labels: Hbase, Thrift
>         Attachments: hbase_7826.patch, hbase_7826.patch, hbase_7826_sortcolumnFlag.patch
>
>
> Hbase natively stores columns sorted based on the column qualifier. A scan is guaranteed
to return sorted columns. The Java API works fine but the Thrift API is broken. Hbase uses
TreeMap that ensures that sort order is maintained. However Hbase thrift specification uses
a simple Map to store the data. A map, since it is unordered doesn't result in columns being
returned in a sort order that is consistent with their storage in Hbase.

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira

Mime
View raw message