Return-Path: X-Original-To: apmail-hbase-issues-archive@www.apache.org Delivered-To: apmail-hbase-issues-archive@www.apache.org Received: from mail.apache.org (hermes.apache.org [140.211.11.3]) by minotaur.apache.org (Postfix) with SMTP id 07B1B10953 for ; Sat, 29 Jun 2013 01:48:21 +0000 (UTC) Received: (qmail 47847 invoked by uid 500); 29 Jun 2013 01:48:20 -0000 Delivered-To: apmail-hbase-issues-archive@hbase.apache.org Received: (qmail 47782 invoked by uid 500); 29 Jun 2013 01:48:20 -0000 Mailing-List: contact issues-help@hbase.apache.org; run by ezmlm Precedence: bulk List-Help: List-Unsubscribe: List-Post: List-Id: Delivered-To: mailing list issues@hbase.apache.org Received: (qmail 47773 invoked by uid 99); 29 Jun 2013 01:48:20 -0000 Received: from arcas.apache.org (HELO arcas.apache.org) (140.211.11.28) by apache.org (qpsmtpd/0.29) with ESMTP; Sat, 29 Jun 2013 01:48:20 +0000 Date: Sat, 29 Jun 2013 01:48:20 +0000 (UTC) From: "Enis Soztutar (JIRA)" To: issues@hbase.apache.org Message-ID: In-Reply-To: References: Subject: [jira] [Updated] (HBASE-8838) [WINDOWS] FileLink assumptions are broken under NTFS MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 7bit X-JIRA-FingerPrint: 30527f35849b9dde25b450d4833f0394 [ https://issues.apache.org/jira/browse/HBASE-8838?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Enis Soztutar updated HBASE-8838: --------------------------------- Attachment: hbase-8838_v1.patch Attaching a simple patch which makes TestFileLink pass on windows by first ensuring that the reader is closed before rename. As per the description, I think we do not need to change the underlying FileLink assumptions at this point. > [WINDOWS] FileLink assumptions are broken under NTFS > ---------------------------------------------------- > > Key: HBASE-8838 > URL: https://issues.apache.org/jira/browse/HBASE-8838 > Project: HBase > Issue Type: Sub-task > Reporter: Enis Soztutar > Assignee: Enis Soztutar > Attachments: hbase-8838_v1.patch > > > FileLink assumes that underlying files can be moved while there are open readers. Windows does not allow the file which has active readers to be moved unless the file is opened in shared mode. JDK6 and 7 open the file in exclusive mode by default, so moving the file while there are readers is not possible. > Hadoop-on-windows copies the file, if it cannot perform the rename. This will cause duplication, and the original file not being deleted. > This affects the unit test TestFileLink. On local mode over NTFS, reading from snapshot files and replication might cause issues, but I don't think it has any other implications on hbase+hdfs on windows. -- This message is automatically generated by JIRA. If you think it was sent incorrectly, please contact your JIRA administrators For more information on JIRA, see: http://www.atlassian.com/software/jira