Return-Path: 
 <issues-return-100754-apmail-hbase-issues-archive=hbase.apache.org@hbase.apache.org>
X-Original-To: apmail-hbase-issues-archive@www.apache.org
Delivered-To: apmail-hbase-issues-archive@www.apache.org
Received: from mail.apache.org (hermes.apache.org [140.211.11.3])
	by minotaur.apache.org (Postfix) with SMTP id D008C10D10
	for <apmail-hbase-issues-archive@www.apache.org>;
 Fri,  7 Jun 2013 09:46:21 +0000 (UTC)
Received: (qmail 86450 invoked by uid 500); 7 Jun 2013 09:46:21 -0000
Delivered-To: apmail-hbase-issues-archive@hbase.apache.org
Received: (qmail 86418 invoked by uid 500); 7 Jun 2013 09:46:21 -0000
Mailing-List: contact issues-help@hbase.apache.org; run by ezmlm
Precedence: bulk
List-Help: <mailto:issues-help@hbase.apache.org>
List-Unsubscribe: <mailto:issues-unsubscribe@hbase.apache.org>
List-Post: <mailto:issues@hbase.apache.org>
List-Id: <issues.hbase.apache.org>
Delivered-To: mailing list issues@hbase.apache.org
Received: (qmail 86375 invoked by uid 99); 7 Jun 2013 09:46:20 -0000
Received: from arcas.apache.org (HELO arcas.apache.org) (140.211.11.28)
    by apache.org (qpsmtpd/0.29) with ESMTP; Fri, 07 Jun 2013 09:46:20 +0000
Date: Fri, 7 Jun 2013 09:46:20 +0000 (UTC)
From: "binlijin (JIRA)" <jira@apache.org>
To: issues@hbase.apache.org
Message-ID: <JIRA.12651651.1370597117295.84087.1370598380023@arcas>
In-Reply-To: <JIRA.12651651.1370597117295@arcas>
References: <JIRA.12651651.1370597117295@arcas>
Subject: [jira] [Updated] (HBASE-8706) Some improvement in snapshot
MIME-Version: 1.0
Content-Type: text/plain; charset=utf-8
Content-Transfer-Encoding: 7bit
X-JIRA-FingerPrint: 30527f35849b9dde25b450d4833f0394


     [ https://issues.apache.org/jira/browse/HBASE-8706?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

binlijin updated HBASE-8706:
----------------------------

    Attachment: HBASE-8706.patch
    
> Some improvement in snapshot
> ----------------------------
>
>                 Key: HBASE-8706
>                 URL: https://issues.apache.org/jira/browse/HBASE-8706
>             Project: HBase
>          Issue Type: Bug
>          Components: snapshots
>    Affects Versions: 0.94.8, 0.95.0
>            Reporter: binlijin
>         Attachments: HBASE-8706.patch
>
>
> (1)timeout for Procedure can not be configured.
> {code}
> Procedure's timeout
> ProcedureCoordinator
>   final static long TIMEOUT_MILLIS_DEFAULT = 60000;
>    createProcedure(ForeignExceptionDispatcher fed, String procName, byte[] procArgs,
>       List<String> expectedMembers) {
>     // build the procedure
>     return new Procedure(this, fed, WAKE_MILLIS_DEFAULT, TIMEOUT_MILLIS_DEFAULT,
>         procName, procArgs, expectedMembers);
>   }
> RegionServerSnapshotManager:
>   /** Conf key for max time to keep threads in snapshot request pool waiting */
>   public static final String SNAPSHOT_TIMEOUT_MILLIS_KEY = "hbase.snapshot.region.timeout";
>   /** Keep threads alive in request pool for max of 60 seconds */
>   public static final long SNAPSHOT_TIMEOUT_MILLIS_DEFAULT = 60000;
>   public Subprocedure buildSubprocedure(SnapshotDescription snapshot) {
>     long timeoutMillis = conf.getLong(SNAPSHOT_TIMEOUT_MILLIS_KEY,
>         SNAPSHOT_TIMEOUT_MILLIS_DEFAULT);
>     case FLUSH:
>       SnapshotSubprocedurePool taskManager =
>         new SnapshotSubprocedurePool(rss.getServerName().toString(), conf);
>   }
> {code}
> (2)TakeSnapshotHandler
> after snapshotRegions we should call monitor.rethrowException(); to check if there is exception and if there is we can skip the verifySnapshot
> (3)too much error message when error happened in some place.

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira