Return-Path: X-Original-To: apmail-hbase-issues-archive@www.apache.org Delivered-To: apmail-hbase-issues-archive@www.apache.org Received: from mail.apache.org (hermes.apache.org [140.211.11.3]) by minotaur.apache.org (Postfix) with SMTP id 78B0B107A7 for ; Tue, 11 Jun 2013 21:44:22 +0000 (UTC) Received: (qmail 77469 invoked by uid 500); 11 Jun 2013 21:44:21 -0000 Delivered-To: apmail-hbase-issues-archive@hbase.apache.org Received: (qmail 77433 invoked by uid 500); 11 Jun 2013 21:44:21 -0000 Mailing-List: contact issues-help@hbase.apache.org; run by ezmlm Precedence: bulk List-Help: List-Unsubscribe: List-Post: List-Id: Delivered-To: mailing list issues@hbase.apache.org Received: (qmail 77406 invoked by uid 99); 11 Jun 2013 21:44:21 -0000 Received: from arcas.apache.org (HELO arcas.apache.org) (140.211.11.28) by apache.org (qpsmtpd/0.29) with ESMTP; Tue, 11 Jun 2013 21:44:21 +0000 Date: Tue, 11 Jun 2013 21:44:21 +0000 (UTC) From: "Ted Yu (JIRA)" To: issues@hbase.apache.org Message-ID: In-Reply-To: References: Subject: [jira] [Commented] (HBASE-8699) Parameter to DistributedFileSystem#isFileClosed should be of type Path MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 7bit X-JIRA-FingerPrint: 30527f35849b9dde25b450d4833f0394 [ https://issues.apache.org/jira/browse/HBASE-8699?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13680719#comment-13680719 ] Ted Yu commented on HBASE-8699: ------------------------------- bq. Anything hadoop 2+ will have hbase-hadoop2-compat on the cp lib/hbase-hadoop2-compat-0.95.1.jar would be on the classpath. Does it reveal the underlying hadoop version ? > Parameter to DistributedFileSystem#isFileClosed should be of type Path > ---------------------------------------------------------------------- > > Key: HBASE-8699 > URL: https://issues.apache.org/jira/browse/HBASE-8699 > Project: HBase > Issue Type: Bug > Components: wal > Reporter: Ted Yu > Assignee: Ted Yu > Attachments: 8699-v1.txt > > > Here is current code of FSHDFSUtils#isFileClosed(): > {code} > boolean isFileClosed(final DistributedFileSystem dfs, final Path p) { > try { > Method m = dfs.getClass().getMethod("isFileClosed", new Class[] {String.class}); > return (Boolean) m.invoke(dfs, p.toString()); > {code} > We look for isFileClosed method with parameter type of String. > However, from hadoop-hdfs-project/hadoop-hdfs/src/main/java/org/apache/hadoop/hdfs/DistributedFileSystem.java (branch-2): > {code} > public boolean isFileClosed(Path src) throws IOException { > {code} > The parameter type is of Path. > This means we would get NoSuchMethodException. -- This message is automatically generated by JIRA. If you think it was sent incorrectly, please contact your JIRA administrators For more information on JIRA, see: http://www.atlassian.com/software/jira