Return-Path: X-Original-To: apmail-hbase-issues-archive@www.apache.org Delivered-To: apmail-hbase-issues-archive@www.apache.org Received: from mail.apache.org (hermes.apache.org [140.211.11.3]) by minotaur.apache.org (Postfix) with SMTP id 7EE9F10272 for ; Thu, 6 Jun 2013 16:09:24 +0000 (UTC) Received: (qmail 51569 invoked by uid 500); 6 Jun 2013 16:09:24 -0000 Delivered-To: apmail-hbase-issues-archive@hbase.apache.org Received: (qmail 50616 invoked by uid 500); 6 Jun 2013 16:09:22 -0000 Mailing-List: contact issues-help@hbase.apache.org; run by ezmlm Precedence: bulk List-Help: List-Unsubscribe: List-Post: List-Id: Delivered-To: mailing list issues@hbase.apache.org Received: (qmail 49949 invoked by uid 99); 6 Jun 2013 16:09:22 -0000 Received: from arcas.apache.org (HELO arcas.apache.org) (140.211.11.28) by apache.org (qpsmtpd/0.29) with ESMTP; Thu, 06 Jun 2013 16:09:22 +0000 Date: Thu, 6 Jun 2013 16:09:21 +0000 (UTC) From: "Matteo Bertozzi (JIRA)" To: issues@hbase.apache.org Message-ID: In-Reply-To: References: Subject: [jira] [Commented] (HBASE-8690) Reduce unnecessary getFileStatus hdfs calls in TTL hfile and hlog cleanners MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 7bit X-JIRA-FingerPrint: 30527f35849b9dde25b450d4833f0394 [ https://issues.apache.org/jira/browse/HBASE-8690?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13677177#comment-13677177 ] Matteo Bertozzi commented on HBASE-8690: ---------------------------------------- there're a couple of places, in the javadoc, where you should replace filePath with fStatus. other than that looks good to me. > Reduce unnecessary getFileStatus hdfs calls in TTL hfile and hlog cleanners > --------------------------------------------------------------------------- > > Key: HBASE-8690 > URL: https://issues.apache.org/jira/browse/HBASE-8690 > Project: HBase > Issue Type: Improvement > Components: master > Reporter: Liu Shaohui > Priority: Minor > Attachments: HBASE-8690-0.94-v1.patch, HBASE-8690-trunk-v1.patch, HBASE-8690-trunk-v2.patch > > > For each in file in archive dir, the TimeToLiveHFileCleaner need call getFileStatus to get the modify time of file. Actually the CleanerChore have had the file status when listing its parent dir. > When we set the TTL to 7 days in our cluster for data security, the number of files left in archive dir is up to 65 thousands. In each clean period, TimeToLiveHFileCleaner will generate ten thousand getFileStatus call in a short time, which is very heavy for hdfs namenode. > Fix: Change the path param to FileStatus in isFileDeletable method and reduce unnecessary getFileStatus hdfs calls in TTL cleaners. -- This message is automatically generated by JIRA. If you think it was sent incorrectly, please contact your JIRA administrators For more information on JIRA, see: http://www.atlassian.com/software/jira