Return-Path: X-Original-To: apmail-hbase-issues-archive@www.apache.org Delivered-To: apmail-hbase-issues-archive@www.apache.org Received: from mail.apache.org (hermes.apache.org [140.211.11.3]) by minotaur.apache.org (Postfix) with SMTP id 1998DC07A for ; Tue, 4 Jun 2013 01:30:21 +0000 (UTC) Received: (qmail 56002 invoked by uid 500); 4 Jun 2013 01:30:20 -0000 Delivered-To: apmail-hbase-issues-archive@hbase.apache.org Received: (qmail 55961 invoked by uid 500); 4 Jun 2013 01:30:20 -0000 Mailing-List: contact issues-help@hbase.apache.org; run by ezmlm Precedence: bulk List-Help: List-Unsubscribe: List-Post: List-Id: Delivered-To: mailing list issues@hbase.apache.org Received: (qmail 55879 invoked by uid 99); 4 Jun 2013 01:30:20 -0000 Received: from arcas.apache.org (HELO arcas.apache.org) (140.211.11.28) by apache.org (qpsmtpd/0.29) with ESMTP; Tue, 04 Jun 2013 01:30:20 +0000 Date: Tue, 4 Jun 2013 01:30:20 +0000 (UTC) From: "Enis Soztutar (JIRA)" To: issues@hbase.apache.org Message-ID: In-Reply-To: References: Subject: [jira] [Commented] (HBASE-8670) [0.94] Backport HBASE-8449 and HBASE-8204 to 0.94 (Refactor recoverLease retries and pauses) MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 7bit X-JIRA-FingerPrint: 30527f35849b9dde25b450d4833f0394 [ https://issues.apache.org/jira/browse/HBASE-8670?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13673913#comment-13673913 ] Enis Soztutar commented on HBASE-8670: -------------------------------------- By 0.94, we are not supporting pre-1 hadoop's. However, isFileClosed() only comes with 1.2, and we should still support 1.0.x and 1.1.x. > [0.94] Backport HBASE-8449 and HBASE-8204 to 0.94 (Refactor recoverLease retries and pauses) > -------------------------------------------------------------------------------------------- > > Key: HBASE-8670 > URL: https://issues.apache.org/jira/browse/HBASE-8670 > Project: HBase > Issue Type: Bug > Components: Filesystem Integration, master, wal > Reporter: Enis Soztutar > Assignee: Enis Soztutar > Fix For: 0.94.9 > > Attachments: hbase-8670_v1.patch > > > Some history: > Up until 0.94.8, Hbase did not check the result of recoverLease() call, but things kind of worked since we are checking for 0-length files in distributed log split tasks from region servers. If lease recovery is not finished, the log file will report 0 length, and the task will fail, and master will then re-call recoverLease() and reassign the task. This scheme might fail for log files that are larger than 1 hdfs block though. > In 0.94.8, we committed (HBASE-8354, which is backport of HBASE-7878) and later increased the sleep time to 4 secs in HBASE-8389. > However, the proper solution arrived in trunk in HBASE-8449 which uses a backoff sleep policy + isFileClosed() api. We should backport this patch to 0.94 as well. > isFileClosed() is released in Hadoop 1.2.0 (HDFS-4774) and 2.0.5(HDFS-4525). -- This message is automatically generated by JIRA. If you think it was sent incorrectly, please contact your JIRA administrators For more information on JIRA, see: http://www.atlassian.com/software/jira