hbase-issues mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Lars George (JIRA)" <j...@apache.org>
Subject [jira] [Commented] (HBASE-8774) Add BatchSize and Filter to Thrift2
Date Sat, 29 Jun 2013 13:17:21 GMT

    [ https://issues.apache.org/jira/browse/HBASE-8774?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13696124#comment-13696124
] 

Lars George commented on HBASE-8774:
------------------------------------

As for the patch

{code}
+typedef binary Text
{code}

We dropped Text from the definition file in Thrift 2 (T1 had it). We now use:

{code}
exception TIOError {
  1: optional string message
}
{code}

In other words "string" (see http://thrift.apache.org/docs/types/). Is there a reason why
you need to use Text? The same page states that "binary" is specific for Java?

{quote}
Special Types
binary: a sequence of unencoded bytes

N.B.: This is currently a specialized form of the string type above, added to provide better
interoperability with Java. The current plan-of-record is to elevate this to a base type at
some point.
{quote}

Should we simply drop the definition of Text and use binary or string inline instead?
                
> Add BatchSize and Filter to Thrift2
> -----------------------------------
>
>                 Key: HBASE-8774
>                 URL: https://issues.apache.org/jira/browse/HBASE-8774
>             Project: HBase
>          Issue Type: Sub-task
>          Components: Thrift
>    Affects Versions: 0.95.1
>            Reporter: Hamed Madani
>            Assignee: Hamed Madani
>              Labels: thrift2
>         Attachments: HBASE_8774.patch, HBASE_8774_v2.patch
>
>
> Attached Patch will add BatchSize and Filter support to Thrift2

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira

Mime
View raw message