hbase-issues mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Andrew Purtell (JIRA)" <j...@apache.org>
Subject [jira] [Commented] (HBASE-8746) Backport HBASE-8672 (Integration test for bulk loads) to 0.94
Date Sat, 15 Jun 2013 20:09:19 GMT

    [ https://issues.apache.org/jira/browse/HBASE-8746?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13684412#comment-13684412
] 

Andrew Purtell commented on HBASE-8746:
---------------------------------------

Passes with Hadoop 1. Needs the following diff (and changes to HBaseTestingUtility from HBASE-8453)
to pass also on Hadoop 2:

{noformat}
diff --git src/test/java/org/apache/hadoop/hbase/IntegrationTestBulkLoad.java src/test/java/org/apac
index 91fa37d..0ee53d2 100644
--- src/test/java/org/apache/hadoop/hbase/IntegrationTestBulkLoad.java
+++ src/test/java/org/apache/hadoop/hbase/IntegrationTestBulkLoad.java
@@ -43,6 +43,7 @@ import org.apache.hadoop.io.Text;
 import org.apache.hadoop.io.WritableComparable;
 import org.apache.hadoop.io.WritableComparator;
 import org.apache.hadoop.io.WritableUtils;
+import org.apache.hadoop.mapred.JobConf;
 import org.apache.hadoop.mapreduce.InputFormat;
 import org.apache.hadoop.mapreduce.InputSplit;
 import org.apache.hadoop.mapreduce.Job;
@@ -168,7 +169,9 @@ public class IntegrationTestBulkLoad implements Configurable, Tool {
     conf.setBoolean("mapreduce.map.speculative", false);
     conf.setBoolean("mapreduce.reduce.speculative", false);
 
-    Job job = new Job(conf);
+    JobConf jobConf = util.getMRCluster().createJobConf();
+    HBaseConfiguration.merge(jobConf, conf);
+    Job job = new Job(jobConf);
 
     job.setJobName(jobName);
 
@@ -537,7 +540,9 @@ public class IntegrationTestBulkLoad implements Configurable, Tool {
     String jobName = tableName + "_check" + EnvironmentEdgeManager.currentTimeMillis();
     Path p = new Path(util.getDataTestDir().toString() + "/"  + jobName);
 
-    Job job = new Job(conf);
+    JobConf jobConf = util.getMRCluster().createJobConf();
+    HBaseConfiguration.merge(jobConf, conf);
+    Job job = new Job(jobConf);
 
     job.setJarByClass(getClass());
 

{noformat}

                
> Backport HBASE-8672 (Integration test for bulk loads) to 0.94
> -------------------------------------------------------------
>
>                 Key: HBASE-8746
>                 URL: https://issues.apache.org/jira/browse/HBASE-8746
>             Project: HBase
>          Issue Type: Improvement
>          Components: test
>    Affects Versions: 0.94.9
>            Reporter: Andrew Purtell
>            Assignee: Andrew Purtell
>         Attachments: 8746.patch
>
>
> Backport HBASE-8672 (Integration test for bulk loads) to 0.94, because it's easy, and
you can never have too many integration tests.

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira

Mime
View raw message