hbase-issues mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Jesse Yates (JIRA)" <j...@apache.org>
Subject [jira] [Commented] (HBASE-8740) Generate unique table names in TestAccessController
Date Wed, 12 Jun 2013 22:48:21 GMT

    [ https://issues.apache.org/jira/browse/HBASE-8740?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13681718#comment-13681718

Jesse Yates commented on HBASE-8740:

+1 looks good to me.

Minor nit:
 @Rule public TableName TEST_TABLE = new TableName();

Maybe move this up out of the regular constants? Its generally better style to write things
somewhat in order that they are run - it makes it a little easier to understand.
> Generate unique table names in TestAccessController
> ---------------------------------------------------
>                 Key: HBASE-8740
>                 URL: https://issues.apache.org/jira/browse/HBASE-8740
>             Project: HBase
>          Issue Type: Improvement
>            Reporter: Alex Araujo
>            Priority: Minor
>         Attachments: HBASE-8740.patch
> This test class creates/drops a table named 'testtable' for 30+ tests.  Having tables
named after each test method may help diagnose test failures.

This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira

View raw message