hbase-issues mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Aleksandr Shulman (JIRA)" <j...@apache.org>
Subject [jira] [Commented] (HBASE-8672) Create an Integration test for Bulk Loads
Date Tue, 04 Jun 2013 22:05:22 GMT

    [ https://issues.apache.org/jira/browse/HBASE-8672?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13675325#comment-13675325
] 

Aleksandr Shulman commented on HBASE-8672:
------------------------------------------

Minor issue -- in {code}runLinkedListMRJob(int iteration){code}, your delete comes at the
end of the function. Should there be an issue and the test fails, it will not reach that point
and there will be leftover cruft that could affect other tests. One way to get around this
is to use a try-catch-finally (or just try-finally) pattern, with the deletion being in the
'finally' portion. 

Granted, you only have one test, but if you write more, or if you run this on an actual cluster,
cleanup becomes important.
                
> Create an Integration test for Bulk Loads
> -----------------------------------------
>
>                 Key: HBASE-8672
>                 URL: https://issues.apache.org/jira/browse/HBASE-8672
>             Project: HBase
>          Issue Type: Bug
>          Components: regionserver, test
>    Affects Versions: 0.98.0, 0.95.1
>            Reporter: Elliott Clark
>            Assignee: Elliott Clark
>         Attachments: HBASE-8672-0.patch, HBASE-8672-1.patch, HBASE-8672-2.patch, HBASE-8672-3.patch
>
>
> Bulk loads and MR are not well tested using our IT tests.  We should add a test that
bulk loads hfiles and then scans over the resulting table to make sure that all the data is
there.

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira

Mime
View raw message