Return-Path: X-Original-To: apmail-hbase-issues-archive@www.apache.org Delivered-To: apmail-hbase-issues-archive@www.apache.org Received: from mail.apache.org (hermes.apache.org [140.211.11.3]) by minotaur.apache.org (Postfix) with SMTP id 6A971D3E0 for ; Tue, 28 May 2013 18:20:22 +0000 (UTC) Received: (qmail 77760 invoked by uid 500); 28 May 2013 18:20:22 -0000 Delivered-To: apmail-hbase-issues-archive@hbase.apache.org Received: (qmail 77554 invoked by uid 500); 28 May 2013 18:20:21 -0000 Mailing-List: contact issues-help@hbase.apache.org; run by ezmlm Precedence: bulk List-Help: List-Unsubscribe: List-Post: List-Id: Delivered-To: mailing list issues@hbase.apache.org Received: (qmail 77283 invoked by uid 99); 28 May 2013 18:20:20 -0000 Received: from arcas.apache.org (HELO arcas.apache.org) (140.211.11.28) by apache.org (qpsmtpd/0.29) with ESMTP; Tue, 28 May 2013 18:20:20 +0000 Date: Tue, 28 May 2013 18:20:20 +0000 (UTC) From: "Jonathan Hsieh (JIRA)" To: issues@hbase.apache.org Message-ID: In-Reply-To: References: Subject: [jira] [Commented] (HBASE-8627) HBCK can not fix meta not assigned issue MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 7bit X-JIRA-FingerPrint: 30527f35849b9dde25b450d4833f0394 [ https://issues.apache.org/jira/browse/HBASE-8627?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13668518#comment-13668518 ] Jonathan Hsieh commented on HBASE-8627: --------------------------------------- Looks good -- have a few nits and places to improve documentation. Also fix the 100line lengh violation? ---- nit: wether -> whether {code} + // check wether .META. is deployed and online {code} What are we planning to remove? the meta entry? this message? {code} + if (!recordMetaRegion()) { + // Will remove later if we can fix it + errors.reportError("Fatal error: unable to get .META. region location. Exiting..."); {code} nit: add space: " Exiting..." {code} + } + errors.reportError(errorMsg + "Exiting..."); return -2; {code} Null is for a coder. Maybe turn this message into something more admin friendly? {code} + errors.reportError(ERROR_CODE.NULL_META_REGION, + "META region or some of its attributes are null."); + return false; {code} style nit: (should be if () {\n ... \n }n {code} HBaseFsckRepair.closeRegionSilentlyAndWait(admin, sn, hri); - admin.offline(hri.getRegionName()); + if(!hri.isMetaTable()) admin.offline(hri.getRegionName()); {code} We need to "fix" it twice? why? (explain with comment please) {code} + // ERROR_CODE.UNKNOWN is coming because we reportError with a message for the .META. + // inconsistency and whether we will be fixing it or not. + assertErrors(hbck, new ERROR_CODE[] { ERROR_CODE.NO_META_REGION, ERROR_CODE.UNKNOWN }); + hbck = doFsck(conf, true); + assertErrors(hbck, new ERROR_CODE[] { ERROR_CODE.NO_META_REGION, ERROR_CODE.UNKNOWN }); + hbck = doFsck(conf, true); {code} > HBCK can not fix meta not assigned issue > ---------------------------------------- > > Key: HBASE-8627 > URL: https://issues.apache.org/jira/browse/HBASE-8627 > Project: HBase > Issue Type: Bug > Components: hbck > Affects Versions: 0.95.0 > Reporter: Anoop Sam John > Assignee: Anoop Sam John > Attachments: HBASE-8627_Trunk.patch > > > When meta table region is not assigned to any RS, HBCK run will get exception. I can see code added in checkMetaRegion() to solve this issue but it wont work. It still refers to ROOT region! -- This message is automatically generated by JIRA. If you think it was sent incorrectly, please contact your JIRA administrators For more information on JIRA, see: http://www.atlassian.com/software/jira