Return-Path: X-Original-To: apmail-hbase-issues-archive@www.apache.org Delivered-To: apmail-hbase-issues-archive@www.apache.org Received: from mail.apache.org (hermes.apache.org [140.211.11.3]) by minotaur.apache.org (Postfix) with SMTP id 95FC5D961 for ; Fri, 24 May 2013 20:37:20 +0000 (UTC) Received: (qmail 33819 invoked by uid 500); 24 May 2013 20:37:20 -0000 Delivered-To: apmail-hbase-issues-archive@hbase.apache.org Received: (qmail 33645 invoked by uid 500); 24 May 2013 20:37:20 -0000 Mailing-List: contact issues-help@hbase.apache.org; run by ezmlm Precedence: bulk List-Help: List-Unsubscribe: List-Post: List-Id: Delivered-To: mailing list issues@hbase.apache.org Received: (qmail 33636 invoked by uid 99); 24 May 2013 20:37:20 -0000 Received: from arcas.apache.org (HELO arcas.apache.org) (140.211.11.28) by apache.org (qpsmtpd/0.29) with ESMTP; Fri, 24 May 2013 20:37:20 +0000 Date: Fri, 24 May 2013 20:37:20 +0000 (UTC) From: "Jeffrey Zhong (JIRA)" To: issues@hbase.apache.org Message-ID: In-Reply-To: References: Subject: [jira] [Commented] (HBASE-8573) Store last flushed sequence id for each store of region for Distributed Log Replay MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 7bit X-JIRA-FingerPrint: 30527f35849b9dde25b450d4833f0394 [ https://issues.apache.org/jira/browse/HBASE-8573?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13666645#comment-13666645 ] Jeffrey Zhong commented on HBASE-8573: -------------------------------------- {quote} When we do this, SplitLogManager.getRegionFlushedSequenceId(this.watcher, failedServerName, key);, where are the ids coming from? We are getting them from zk? How do they get into zk from the region open? {quote} SplitLogManager.getRegionFlushedSequenceId are called twice: the first one is in pre filtering edits read from a wal. The other place is called after HLogSplitter#waitUntilRegionOnline to get up to date sequenced Ids. During region open(HRegionServer#postOpenDeployTasks#updateRecoveringRegionLastFlushedSequenceId), we'll update these ids in ZK to replace the values from master. ids firstly comes from HMaster and they're only used in pre-filtering. Later of the replay, these ids are then updated by the values of HRegion#getMaxStoreSeqIdForLogReplay during region opening. > Store last flushed sequence id for each store of region for Distributed Log Replay > ---------------------------------------------------------------------------------- > > Key: HBASE-8573 > URL: https://issues.apache.org/jira/browse/HBASE-8573 > Project: HBase > Issue Type: Improvement > Reporter: Ted Yu > Assignee: Jeffrey Zhong > Attachments: hbase-8573.patch, hbase-8573-v1.patch > > > HBASE-7006 stores last flushed sequence id of the region in zookeeper. > To prevent deleted data from appearing again, we should store last flushed sequence id for each store of region in zookeeper. > See discussion here: > https://issues.apache.org/jira/browse/HBASE-7006?focusedCommentId=13660428&page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel#comment-13660428 -- This message is automatically generated by JIRA. If you think it was sent incorrectly, please contact your JIRA administrators For more information on JIRA, see: http://www.atlassian.com/software/jira