Return-Path: X-Original-To: apmail-hbase-issues-archive@www.apache.org Delivered-To: apmail-hbase-issues-archive@www.apache.org Received: from mail.apache.org (hermes.apache.org [140.211.11.3]) by minotaur.apache.org (Postfix) with SMTP id 5A54DDC7D for ; Thu, 30 May 2013 15:34:22 +0000 (UTC) Received: (qmail 81671 invoked by uid 500); 30 May 2013 15:34:21 -0000 Delivered-To: apmail-hbase-issues-archive@hbase.apache.org Received: (qmail 81430 invoked by uid 500); 30 May 2013 15:34:21 -0000 Mailing-List: contact issues-help@hbase.apache.org; run by ezmlm Precedence: bulk List-Help: List-Unsubscribe: List-Post: List-Id: Delivered-To: mailing list issues@hbase.apache.org Received: (qmail 81392 invoked by uid 99); 30 May 2013 15:34:21 -0000 Received: from arcas.apache.org (HELO arcas.apache.org) (140.211.11.28) by apache.org (qpsmtpd/0.29) with ESMTP; Thu, 30 May 2013 15:34:21 +0000 Date: Thu, 30 May 2013 15:34:21 +0000 (UTC) From: "Nick Dimiduk (JIRA)" To: issues@hbase.apache.org Message-ID: In-Reply-To: References: Subject: [jira] [Commented] (HBASE-8534) fix coverage org.apache.hadoop.hbase.mapreduce MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 7bit X-JIRA-FingerPrint: 30527f35849b9dde25b450d4833f0394 [ https://issues.apache.org/jira/browse/HBASE-8534?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13670411#comment-13670411 ] Nick Dimiduk commented on HBASE-8534: ------------------------------------- Regarding the junit tests being run in an isolated environment with default configs, I think you're right, that should be the common case. I'm thinking about a user who is running the test suite as a post-install smoke-test (as I believe we are advocating for 0.95+). In that scenario, their site-config can be picked up. I expect they would be running integration tests only, so this is probably fine. Regarding ExitUtil, managing shared state in ExitUtil is equivalent to overriding the shared state that is a SecurityManager. I'd rather see the SecurityManager (with my previous comment about the constructor logic being fixed) over this ExitUtil implementation; the SecurityManager is less intrusive to non-test code. [~nkeywal], [~apurtell] do either of you have an opinion on ExitUtil vs the custom SecurityManager in patch e? > fix coverage org.apache.hadoop.hbase.mapreduce > ---------------------------------------------- > > Key: HBASE-8534 > URL: https://issues.apache.org/jira/browse/HBASE-8534 > Project: HBase > Issue Type: Test > Affects Versions: 0.94.8, 0.95.2 > Reporter: Aleksey Gorshkov > Attachments: HBASE-8534-0.94-d.patch, HBASE-8534-0.94-e.patch, HBASE-8534-0.94-f.patch, HBASE-8534-0.94.patch, HBASE-8534-trunk-a.patch, HBASE-8534-trunk-b.patch, HBASE-8534-trunk-c.patch, HBASE-8534-trunk-d.patch, HBASE-8534-trunk-e.patch, HBASE-8534-trunk-f.patch, HBASE-8534-trunk.patch > > > fix coverage org.apache.hadoop.hbase.mapreduce > patch HBASE-8534-0.94.patch for branch-0.94 > patch HBASE-8534-trunk.patch for branch-0.95 and trunk -- This message is automatically generated by JIRA. If you think it was sent incorrectly, please contact your JIRA administrators For more information on JIRA, see: http://www.atlassian.com/software/jira