Return-Path: X-Original-To: apmail-hbase-issues-archive@www.apache.org Delivered-To: apmail-hbase-issues-archive@www.apache.org Received: from mail.apache.org (hermes.apache.org [140.211.11.3]) by minotaur.apache.org (Postfix) with SMTP id 2590D11C83 for ; Sat, 11 May 2013 02:07:17 +0000 (UTC) Received: (qmail 68631 invoked by uid 500); 11 May 2013 02:07:16 -0000 Delivered-To: apmail-hbase-issues-archive@hbase.apache.org Received: (qmail 68571 invoked by uid 500); 11 May 2013 02:07:16 -0000 Mailing-List: contact issues-help@hbase.apache.org; run by ezmlm Precedence: bulk List-Help: List-Unsubscribe: List-Post: List-Id: Delivered-To: mailing list issues@hbase.apache.org Received: (qmail 68559 invoked by uid 99); 11 May 2013 02:07:16 -0000 Received: from arcas.apache.org (HELO arcas.apache.org) (140.211.11.28) by apache.org (qpsmtpd/0.29) with ESMTP; Sat, 11 May 2013 02:07:16 +0000 Date: Sat, 11 May 2013 02:07:16 +0000 (UTC) From: "Enis Soztutar (JIRA)" To: issues@hbase.apache.org Message-ID: In-Reply-To: References: Subject: [jira] [Commented] (HBASE-8450) Update hbase-default.xml and general recommendations to better suit current hw, h2, experience, etc. MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 7bit X-JIRA-FingerPrint: 30527f35849b9dde25b450d4833f0394 [ https://issues.apache.org/jira/browse/HBASE-8450?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13655109#comment-13655109 ] Enis Soztutar commented on HBASE-8450: -------------------------------------- bq. Also are we adding all the configs to xml when it is getting added to code? I doubt this.. I have checked with 94 code base some time back and I was able to find some of the configs only referred in code but not in hbase-default.xml I agree to the concern. I always saw this as a three tiered approach. (1)There are configs which are changed in every hbase-site. (2) There are some configs that you may or may not want to changed. (3) And there are configs that only if you know the code, and something crazy happens, you want to change it. For 1, and 2, they should live in hbase-default. for 3, I agree with Stack, that we should not pollute hbase-default too much. However, I have seen some (2) cases but the config was not in hbase-default. I think we should just fix those cases. > Update hbase-default.xml and general recommendations to better suit current hw, h2, experience, etc. > ---------------------------------------------------------------------------------------------------- > > Key: HBASE-8450 > URL: https://issues.apache.org/jira/browse/HBASE-8450 > Project: HBase > Issue Type: Task > Components: Usability > Reporter: stack > Priority: Critical > Fix For: 0.95.1 > > Attachments: 8450.txt > > > This is a critical task we need to do before we release; review our defaults. > On cursory review, there are configs in hbase-default.xml that no longer have matching code; there are some that should be changed because we know better now and others that should be amended because hardware and deploys are bigger than they used to be. > We could also move stuff around so that the must-edit stuff is near the top (zk quorum config. is mid-way down the page) and beef up the descriptions -- especially since these descriptions shine through in the refguide. > Lastly, I notice that our tgz does not "include" an hbase-default.xml other than the one bundled up in the jar. Maybe we should make it more accessible. -- This message is automatically generated by JIRA. If you think it was sent incorrectly, please contact your JIRA administrators For more information on JIRA, see: http://www.atlassian.com/software/jira