Return-Path: X-Original-To: apmail-hbase-issues-archive@www.apache.org Delivered-To: apmail-hbase-issues-archive@www.apache.org Received: from mail.apache.org (hermes.apache.org [140.211.11.3]) by minotaur.apache.org (Postfix) with SMTP id E2875D7B9 for ; Thu, 16 May 2013 05:21:23 +0000 (UTC) Received: (qmail 95097 invoked by uid 500); 16 May 2013 05:21:23 -0000 Delivered-To: apmail-hbase-issues-archive@hbase.apache.org Received: (qmail 95058 invoked by uid 500); 16 May 2013 05:21:23 -0000 Mailing-List: contact issues-help@hbase.apache.org; run by ezmlm Precedence: bulk List-Help: List-Unsubscribe: List-Post: List-Id: Delivered-To: mailing list issues@hbase.apache.org Received: (qmail 95044 invoked by uid 99); 16 May 2013 05:21:23 -0000 Received: from arcas.apache.org (HELO arcas.apache.org) (140.211.11.28) by apache.org (qpsmtpd/0.29) with ESMTP; Thu, 16 May 2013 05:21:23 +0000 Date: Thu, 16 May 2013 05:21:23 +0000 (UTC) From: "Hudson (JIRA)" To: issues@hbase.apache.org Message-ID: In-Reply-To: References: Subject: [jira] [Commented] (HBASE-7380) [replication] When transferring queues, check if the peer still exists before copying the znodes MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 7bit X-JIRA-FingerPrint: 30527f35849b9dde25b450d4833f0394 [ https://issues.apache.org/jira/browse/HBASE-7380?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13659239#comment-13659239 ] Hudson commented on HBASE-7380: ------------------------------- Integrated in HBase-TRUNK-on-Hadoop-2.0.0 #532 (See [https://builds.apache.org/job/HBase-TRUNK-on-Hadoop-2.0.0/532/]) HBASE-7380 [replication] When transferring queues, check if the peer still exists before copying the znodes (Revision 1483136) Result = FAILURE jdcryans : Files : * /hbase/trunk/hbase-client/src/main/java/org/apache/hadoop/hbase/replication/ReplicationQueueInfo.java * /hbase/trunk/hbase-client/src/main/java/org/apache/hadoop/hbase/replication/ReplicationQueuesZKImpl.java * /hbase/trunk/hbase-client/src/main/java/org/apache/hadoop/hbase/replication/ReplicationStateZKBase.java * /hbase/trunk/hbase-client/src/main/java/org/apache/hadoop/hbase/replication/ReplicationZookeeper.java * /hbase/trunk/hbase-server/src/main/java/org/apache/hadoop/hbase/replication/regionserver/ReplicationSource.java * /hbase/trunk/hbase-server/src/test/java/org/apache/hadoop/hbase/replication/TestReplicationStateZKImpl.java * /hbase/trunk/hbase-server/src/test/java/org/apache/hadoop/hbase/replication/regionserver/TestReplicationSourceManager.java > [replication] When transferring queues, check if the peer still exists before copying the znodes > ------------------------------------------------------------------------------------------------ > > Key: HBASE-7380 > URL: https://issues.apache.org/jira/browse/HBASE-7380 > Project: HBase > Issue Type: Bug > Components: Replication, Usability > Affects Versions: 0.94.3 > Reporter: Jean-Daniel Cryans > Assignee: Jean-Daniel Cryans > Fix For: 0.98.0, 0.95.1 > > Attachments: HBASE-7380-0.94.patch, HBASE-7380-v3.patch > > > Right now it's a pain if you remove a peer and still have rogue queues because they get moved on and on and on. NodeFailoverWorker needs to run the check: > bq. if (!zkHelper.getPeerClusters().containsKey(src.getPeerClusterId())) { > before this: > bq. SortedMap> newQueues = zkHelper.copyQueuesFromRS(rsZnode); > And test. -- This message is automatically generated by JIRA. If you think it was sent incorrectly, please contact your JIRA administrators For more information on JIRA, see: http://www.atlassian.com/software/jira