Mailing-List: contact issues-help@hbase.apache.org; run by ezmlm
Precedence: bulk
Date: Tue, 7 May 2013 02:47:16 +0000 (UTC)
From: "Hadoop QA (JIRA)" <jira@apache.org>
To: issues@hbase.apache.org
Message-ID: <JIRA.12615231.1352323125362.277616.1367894836167@arcas>
In-Reply-To: <JIRA.12615231.1352323125362@arcas>
References: <JIRA.12615231.1352323125362@arcas>
Subject: [jira] [Commented] (HBASE-7115) [shell] Provide a way to register
 custom filters with the Filter Language Parser
MIME-Version: 1.0
Content-Type: text/plain; charset=utf-8
Content-Transfer-Encoding: quoted-printable


    [ https://issues.apache.org/jira/browse/HBASE-7115?page=3Dcom.atlassian=
.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=3D1365=
0423#comment-13650423 ]=20

Hadoop QA commented on HBASE-7115:
----------------------------------

{color:red}-1 overall{color}.  Here are the results of testing the latest a=
ttachment=20
  http://issues.apache.org/jira/secure/attachment/12581929/HBASE-7115_trunk=
_v2.patch
  against trunk revision .

    {color:green}+1 @author{color}.  The patch does not contain any @author=
 tags.

    {color:red}-1 tests included{color}.  The patch doesn't appear to inclu=
de any new or modified tests.
                        Please justify why no new tests are needed for this=
 patch.
                        Also please list what manual steps were performed t=
o verify this patch.

    {color:green}+1 hadoop1.0{color}.  The patch compiles against the hadoo=
p 1.0 profile.

    {color:green}+1 hadoop2.0{color}.  The patch compiles against the hadoo=
p 2.0 profile.

    {color:green}+1 javadoc{color}.  The javadoc tool did not generate any =
warning messages.

    {color:green}+1 javac{color}.  The applied patch does not increase the =
total number of javac compiler warnings.

    {color:green}+1 findbugs{color}.  The patch does not introduce any new =
Findbugs (version 1.3.9) warnings.

    {color:green}+1 release audit{color}.  The applied patch does not incre=
ase the total number of release audit warnings.

    {color:green}+1 lineLengths{color}.  The patch does not introduce lines=
 longer than 100

  {color:green}+1 site{color}.  The mvn site goal succeeds with this patch.

    {color:green}+1 core tests{color}.  The patch passed unit tests in .

Test results: https://builds.apache.org/job/PreCommit-HBASE-Build/5565//tes=
tReport/
Findbugs warnings: https://builds.apache.org/job/PreCommit-HBASE-Build/5565=
//artifact/trunk/patchprocess/newPatchFindbugsWarningshbase-prefix-tree.htm=
l
Findbugs warnings: https://builds.apache.org/job/PreCommit-HBASE-Build/5565=
//artifact/trunk/patchprocess/newPatchFindbugsWarningshbase-client.html
Findbugs warnings: https://builds.apache.org/job/PreCommit-HBASE-Build/5565=
//artifact/trunk/patchprocess/newPatchFindbugsWarningshbase-common.html
Findbugs warnings: https://builds.apache.org/job/PreCommit-HBASE-Build/5565=
//artifact/trunk/patchprocess/newPatchFindbugsWarningshbase-protocol.html
Findbugs warnings: https://builds.apache.org/job/PreCommit-HBASE-Build/5565=
//artifact/trunk/patchprocess/newPatchFindbugsWarningshbase-server.html
Findbugs warnings: https://builds.apache.org/job/PreCommit-HBASE-Build/5565=
//artifact/trunk/patchprocess/newPatchFindbugsWarningshbase-hadoop1-compat.=
html
Findbugs warnings: https://builds.apache.org/job/PreCommit-HBASE-Build/5565=
//artifact/trunk/patchprocess/newPatchFindbugsWarningshbase-examples.html
Findbugs warnings: https://builds.apache.org/job/PreCommit-HBASE-Build/5565=
//artifact/trunk/patchprocess/newPatchFindbugsWarningshbase-hadoop-compat.h=
tml
Console output: https://builds.apache.org/job/PreCommit-HBASE-Build/5565//c=
onsole

This message is automatically generated.
               =20
> [shell] Provide a way to register custom filters with the Filter Language=
 Parser
> -------------------------------------------------------------------------=
-------
>
>                 Key: HBASE-7115
>                 URL: https://issues.apache.org/jira/browse/HBASE-7115
>             Project: HBase
>          Issue Type: Improvement
>          Components: Filters, shell
>    Affects Versions: 0.95.2
>            Reporter: Aditya Kishore
>            Assignee: Aditya Kishore
>             Fix For: 0.95.2
>
>         Attachments: HBASE-7115_trunk.patch, HBASE-7115_trunk.patch, HBAS=
E-7115_trunk_v2.patch
>
>
> HBASE-5428 added this capability to thrift interface but the configuratio=
n parameter name is "thrift" specific.
> This patch introduces a more generic parameter "hbase.user.filters" using=
 which the user defined custom filters can be specified in the configuratio=
n and loaded in any client that needs to use the filter language parser.
> The patch then uses this new parameter to register any user specified fil=
ters while invoking the HBase shell.
> Example usage: Let's say I have written a couple of custom filters with c=
lass names *{{org.apache.hadoop.hbase.filter.custom.SuperDuperFilter}}* and=
 *{{org.apache.hadoop.hbase.filter.custom.SilverBulletFilter}}* and I want =
to use them from HBase shell using the filter language.
> To do that, I would add the following configuration to {{hbase-site.xml}}
> {panel}{{<property>}}
> {{=C2=A0=C2=A0<name>hbase.user.filters</name>}}
> {{=C2=A0=C2=A0<value>}}*{{SuperDuperFilter}}*{{:org.apache.hadoop.hbase.f=
ilter.custom.SuperDuperFilter,}}*{{SilverBulletFilter}}*{{:org.apache.hadoo=
p.hbase.filter.custom.SilverBulletFilter</value>}}
> {{</property>}}{panel}
> Once this is configured, I can launch HBase shell and use these filters i=
n my {{get}} or {{scan}} just the way I would use a built-in filter.
> {code}
> hbase(main):001:0> scan 't', {FILTER =3D> "SuperDuperFilter(true) AND Sil=
verBulletFilter(42)"}
> ROW                                                          COLUMN+CELL
>  status                                                      column=3Dcf:=
a, timestamp=3D304385520000, value=3Dworld_peace
> 1 row(s) in 0.0000 seconds
> {code}
> To use this feature in any client, the client needs to make the following=
 function call as part of its initialization.
> {code}
> ParseFilter.registerUserFilters(configuration);
> {code}

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrato=
rs
For more information on JIRA, see: http://www.atlassian.com/software/jira