hbase-issues mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Jesse Yates (JIRA)" <j...@apache.org>
Subject [jira] [Updated] (HBASE-8671) Per-region WAL breaks CP backwards compatibility in 0.94 for non-enabled case
Date Fri, 31 May 2013 22:46:20 GMT

     [ https://issues.apache.org/jira/browse/HBASE-8671?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel

Jesse Yates updated HBASE-8671:

    Attachment: hbase-8671-v0.patch

A (simple) couple line patch that just adds the signature back in, since its still supported
in HRegionServer and does the correct thing (passes null to getWAL(HRegionInfo)).

Hoping to check this in early next week, if there aren't any objections.
> Per-region WAL breaks CP backwards compatibility in 0.94 for non-enabled case
> -----------------------------------------------------------------------------
>                 Key: HBASE-8671
>                 URL: https://issues.apache.org/jira/browse/HBASE-8671
>             Project: HBase
>          Issue Type: Bug
>            Reporter: Jesse Yates
>            Assignee: Jesse Yates
>         Attachments: hbase-8671-v0.patch
> Moving from a single WAL to the possibility of multiple WALs, the method signature in
RegionServerServices became:
> {code}
>   /** @return the HLog for a particular region. Pass null for getting the
>    * default (common) WAL */
>   public HLog getWAL(HRegionInfo regionInfo) throws IOException;
> {code}
> However, CPs that previously needed access to the WAL would just call:
> {code}
> RegionServerServices.getWAL();
> {code}
> Which is equivalent to calling:
> {code}
> RegionServerServices.getWAL(null);
> {code}
> but which requires a code change, recompilation, and possibly an additional compatibility
layer for _different versions of 0.94_... not a great situation.

This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira

View raw message