hbase-issues mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "chunhui shen (JIRA)" <j...@apache.org>
Subject [jira] [Commented] (HBASE-8634) Fix potential null pointer dereference in HRegionServer and TableLockChecker
Date Wed, 29 May 2013 03:30:20 GMT

    [ https://issues.apache.org/jira/browse/HBASE-8634?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13668962#comment-13668962
] 

chunhui shen commented on HBASE-8634:
-------------------------------------

line 2918 in HRegionServer:
{code}
      if (cellsToReturn != null) {
        controller.setCellScanner(cellsToReturn.cellScanner());
      }
{code}
I think NULL check should also be done here.

patch is ok, +1 
                
> Fix potential null pointer dereference in HRegionServer and TableLockChecker
> ----------------------------------------------------------------------------
>
>                 Key: HBASE-8634
>                 URL: https://issues.apache.org/jira/browse/HBASE-8634
>             Project: HBase
>          Issue Type: Bug
>            Reporter: Ted Yu
>            Assignee: Ted Yu
>            Priority: Minor
>         Attachments: 8634-v1.txt
>
>
> From https://builds.apache.org/job/PreCommit-HBASE-Build/5852//artifact/trunk/patchprocess/newPatchFindbugsWarningshbase-server.html
:
> {code}
> <td>Possible null pointer dereference of rpcc in org.apache.hadoop.hbase.regionserver.HRegionServer.multi(RpcController,
ClientProtos$MultiRequest)</td>
> </tr>
> <tr class="detailrow0">
> <td/>
> <td>
> <p id="N69637" style="display: none;">
> <a href="#NP_NULL_ON_SOME_PATH">Bug type NP_NULL_ON_SOME_PATH (click for details)</a>
> <br/>In class org.apache.hadoop.hbase.regionserver.HRegionServer<br/>In method
org.apache.hadoop.hbase.regionserver.HRegionServer.multi(RpcController, ClientProtos$MultiRequest)<br/>Value
loaded from rpcc<br/>Dereferenced at HRegionServer.java:[line 3176]<br/>Known
null at HRegionServer.java:[line 3174]</p>
> ...
> <td>Possible null pointer dereference of rpcc in org.apache.hadoop.hbase.regionserver.HRegionServer.mutate(RpcController,
ClientProtos$MutateRequest)</td>
> </tr>
> <tr class="detailrow1">
> <td/>
> <td>
> <p id="N69712" style="display: none;">
> <a href="#NP_NULL_ON_SOME_PATH">Bug type NP_NULL_ON_SOME_PATH (click for details)</a>
> <br/>In class org.apache.hadoop.hbase.regionserver.HRegionServer<br/>In method
org.apache.hadoop.hbase.regionserver.HRegionServer.mutate(RpcController, ClientProtos$MutateRequest)<br/>Value
loaded from rpcc<br/>Dereferenced at HRegionServer.java:[line 2832]<br/>Known
null at HRegionServer.java:[line 2830]</p>
> ...
> <td>Possible null pointer dereference of rpcc in org.apache.hadoop.hbase.regionserver.HRegionServer.replay(RpcController,
ClientProtos$MultiRequest)</td>
> </tr>
> <tr class="detailrow0">
> <td/>
> <td>
> <p id="N69787" style="display: none;">
> <a href="#NP_NULL_ON_SOME_PATH">Bug type NP_NULL_ON_SOME_PATH (click for details)</a>
> <br/>In class org.apache.hadoop.hbase.regionserver.HRegionServer<br/>In method
org.apache.hadoop.hbase.regionserver.HRegionServer.replay(RpcController, ClientProtos$MultiRequest)<br/>Value
loaded from rpcc<br/>Dereferenced at HRegionServer.java:[line 3742]<br/>Known
null at HRegionServer.java:[line 3740]</p>
> ...
> <td>Possible null pointer dereference of data in org.apache.hadoop.hbase.util.hbck.TableLockChecker$1.handleMetadata(byte[])</td>
> </tr>
> <tr class="detailrow1">
> <td/>
> <td>
> <p id="N73108" style="display: none;">
> <a href="#NP_NULL_ON_SOME_PATH">Bug type NP_NULL_ON_SOME_PATH (click for details)</a>
> <br/>In class org.apache.hadoop.hbase.util.hbck.TableLockChecker$1<br/>In
method org.apache.hadoop.hbase.util.hbck.TableLockChecker$1.handleMetadata(byte[])<br/>Value
loaded from data<br/>Dereferenced at TableLockChecker.java:[line 68]<br/>Known
null at TableLockChecker.java:[line 60]</p>
> {code}

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira

Mime
View raw message