hbase-issues mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Jonathan Hsieh (JIRA)" <j...@apache.org>
Subject [jira] [Commented] (HBASE-8627) HBCK can not fix meta not assigned issue
Date Tue, 28 May 2013 18:20:20 GMT

    [ https://issues.apache.org/jira/browse/HBASE-8627?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13668518#comment-13668518
] 

Jonathan Hsieh commented on HBASE-8627:
---------------------------------------

Looks good -- have a few nits and places to improve documentation.  Also fix the 100line lengh
violation?

----

nit: wether -> whether
{code}
+    // check wether .META. is deployed and online
{code}

What are we planning to remove? the meta entry? this message?
{code}
+    if (!recordMetaRegion()) {
+      // Will remove later if we can fix it
+      errors.reportError("Fatal error: unable to get .META. region location. Exiting...");
{code}

nit: add space: " Exiting..."
{code} 
+      }
+      errors.reportError(errorMsg + "Exiting...");
       return -2;
{code}

Null is for a coder.  Maybe turn this message into something more admin friendly?
{code}
+      errors.reportError(ERROR_CODE.NULL_META_REGION,
+          "META region or some of its attributes are null.");
+      return false;
{code}

style nit: (should be if () {\n ... \n }n
{code}
       HBaseFsckRepair.closeRegionSilentlyAndWait(admin, sn, hri);
-      admin.offline(hri.getRegionName());
+      if(!hri.isMetaTable()) admin.offline(hri.getRegionName());
{code}

We need to "fix" it twice?  why? (explain with comment please)
{code}
+    // ERROR_CODE.UNKNOWN is coming because we reportError with a message for the .META.
+    // inconsistency and whether we will be fixing it or not.
+    assertErrors(hbck, new ERROR_CODE[] { ERROR_CODE.NO_META_REGION, ERROR_CODE.UNKNOWN });
+    hbck = doFsck(conf, true);
+    assertErrors(hbck, new ERROR_CODE[] { ERROR_CODE.NO_META_REGION, ERROR_CODE.UNKNOWN });
+    hbck = doFsck(conf, true);
{code}
                
> HBCK can not fix meta not assigned issue
> ----------------------------------------
>
>                 Key: HBASE-8627
>                 URL: https://issues.apache.org/jira/browse/HBASE-8627
>             Project: HBase
>          Issue Type: Bug
>          Components: hbck
>    Affects Versions: 0.95.0
>            Reporter: Anoop Sam John
>            Assignee: Anoop Sam John
>         Attachments: HBASE-8627_Trunk.patch
>
>
> When meta table region is not assigned to any RS, HBCK run will get exception. I can
see code added in checkMetaRegion() to solve this issue but it wont work. It still refers
to ROOT region!

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira

Mime
View raw message