hbase-issues mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Anoop Sam John (JIRA)" <j...@apache.org>
Subject [jira] [Commented] (HBASE-8609) Make the CopyTable support startRow, stopRow options
Date Tue, 28 May 2013 04:10:32 GMT

    [ https://issues.apache.org/jira/browse/HBASE-8609?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13668059#comment-13668059
] 

Anoop Sam John commented on HBASE-8609:
---------------------------------------

NULL check should be done as createSubmittableJob() can return null.

{code}
+  public void testStartStopRow() throws Exception {
+    final byte[] TABLENAME1 = Bytes.toBytes("testCopyTable1");
+    final byte[] TABLENAME2 = Bytes.toBytes("testCopyTable2");
{code}
We normally name the table with same name as the test method names. Can go with testStartStopRow1
& testStartStopRow2?

Other than these +1.
                
> Make the CopyTable support startRow, stopRow options
> ----------------------------------------------------
>
>                 Key: HBASE-8609
>                 URL: https://issues.apache.org/jira/browse/HBASE-8609
>             Project: HBase
>          Issue Type: Improvement
>          Components: mapreduce
>            Reporter: Liu Shaohui
>            Assignee: Liu Shaohui
>            Priority: Minor
>         Attachments: HBASE-8609-0.94-v0.patch, HBASE-8609-0.94-v1.patch, HBASE-8609-trunk-v0.patch,
HBASE-8609-trunk-v1.patch, HBASE-8609-trunk-v2.patch
>
>
> Make the CopyTable support startRow, stopRow options.

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira

Mime
View raw message