hbase-issues mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "stack (JIRA)" <j...@apache.org>
Subject [jira] [Commented] (HBASE-8535) Test for zk leak does not account for unsynchronized access to zk watcher
Date Wed, 15 May 2013 20:21:16 GMT

    [ https://issues.apache.org/jira/browse/HBASE-8535?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13658745#comment-13658745
] 

stack commented on HBASE-8535:
------------------------------

[~ericyu] 'stale' is a judgement made on a Connection by a HConnectionManager when close is
called -- the connection is being aborted/abandoned so all bets are off ... crash it down
and clean up all resources overriding all usual cleanup mechanisms to do stuff like force
cleanup of the zk ignoring the reference counting the connection is doing so connections are
reused rather than estabilished every time.  Would NOT calling deleteStaleConnection be a
better test, instead just calling a close o the connection in your background thread?  Would
it repro what you were seeing from your app; i.e. if all connections closed, then should be
no outstanding zks?  Do you need an api to see if zk still up?
                
> Test for zk leak does not account for unsynchronized access to zk watcher
> -------------------------------------------------------------------------
>
>                 Key: HBASE-8535
>                 URL: https://issues.apache.org/jira/browse/HBASE-8535
>             Project: HBase
>          Issue Type: Test
>          Components: Client
>    Affects Versions: 0.98.0, 0.95.1
>            Reporter: Eric Yu
>            Assignee: stack
>             Fix For: 0.98.0, 0.95.1
>
>         Attachments: HBASE-8535.patch
>
>
> Test can detect a live zk connection in a closed hconnection because it does not accesses
the zk watcher in a synchronized manner. 

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira

Mime
View raw message