hbase-issues mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Anoop Sam John (JIRA)" <j...@apache.org>
Subject [jira] [Commented] (HBASE-8534) fix coverage org.apache.hadoop.hbase.mapreduce
Date Fri, 31 May 2013 16:48:20 GMT

    [ https://issues.apache.org/jira/browse/HBASE-8534?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13671636#comment-13671636
] 

Anoop Sam John commented on HBASE-8534:
---------------------------------------

testIndexBuilder() 
{code}
when(result.getValue(Bytes.toBytes("attributes"), Bytes.toBytes("column1"))).thenReturn(
+        Bytes.toBytes("test"));
{code}
The CF name we have used is "columnFamily". This was hard coded to "attributes" in IndexBuilder
which was corrected in HBASE-8641. So the actual code will call result.getValue("columnFamily",...)
now. Pls correct in test also.
Why I said mini cluster FT is better is even with the above bug present, the test case was
not able to find it. :(
In some other test cases I can see mini cluster usage now. It is ok to go with mock in testIndexBuilder.

If the QA passes, +1 for commit.
                
> fix coverage org.apache.hadoop.hbase.mapreduce
> ----------------------------------------------
>
>                 Key: HBASE-8534
>                 URL: https://issues.apache.org/jira/browse/HBASE-8534
>             Project: HBase
>          Issue Type: Test
>    Affects Versions: 0.94.8, 0.95.2
>            Reporter: Aleksey Gorshkov
>            Assignee: Aleksey Gorshkov
>         Attachments: HBASE-8534-0.94-d.patch, HBASE-8534-0.94-e.patch, HBASE-8534-0.94-f.patch,
HBASE-8534-0.94-g.patch, HBASE-8534-0.94.patch, HBASE-8534-trunk-a.patch, HBASE-8534-trunk-b.patch,
HBASE-8534-trunk-c.patch, HBASE-8534-trunk-d.patch, HBASE-8534-trunk-e.patch, HBASE-8534-trunk-f.patch,
HBASE-8534-trunk-g.patch, HBASE-8534-trunk.patch
>
>
> fix coverage org.apache.hadoop.hbase.mapreduce
> patch HBASE-8534-0.94.patch for branch-0.94
> patch HBASE-8534-trunk.patch for branch-0.95 and trunk

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira

Mime
View raw message