hbase-issues mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Nick Dimiduk (JIRA)" <j...@apache.org>
Subject [jira] [Commented] (HBASE-8534) fix coverage org.apache.hadoop.hbase.mapreduce
Date Thu, 30 May 2013 15:34:21 GMT

    [ https://issues.apache.org/jira/browse/HBASE-8534?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13670411#comment-13670411
] 

Nick Dimiduk commented on HBASE-8534:
-------------------------------------

Regarding the junit tests being run in an isolated environment with default configs, I think
you're right, that should be the common case. I'm thinking about a user who is running the
test suite as a post-install smoke-test (as I believe we are advocating for 0.95+). In that
scenario, their site-config can be picked up. I expect they would be running integration tests
only, so this is probably fine.

Regarding ExitUtil, managing shared state in ExitUtil is equivalent to overriding the shared
state that is a SecurityManager. I'd rather see the SecurityManager (with my previous comment
about the constructor logic being fixed) over this ExitUtil implementation; the SecurityManager
is less intrusive to non-test code.

[~nkeywal], [~apurtell] do either of you have an opinion on ExitUtil vs the custom SecurityManager
in patch e?
                
> fix coverage org.apache.hadoop.hbase.mapreduce
> ----------------------------------------------
>
>                 Key: HBASE-8534
>                 URL: https://issues.apache.org/jira/browse/HBASE-8534
>             Project: HBase
>          Issue Type: Test
>    Affects Versions: 0.94.8, 0.95.2
>            Reporter: Aleksey Gorshkov
>         Attachments: HBASE-8534-0.94-d.patch, HBASE-8534-0.94-e.patch, HBASE-8534-0.94-f.patch,
HBASE-8534-0.94.patch, HBASE-8534-trunk-a.patch, HBASE-8534-trunk-b.patch, HBASE-8534-trunk-c.patch,
HBASE-8534-trunk-d.patch, HBASE-8534-trunk-e.patch, HBASE-8534-trunk-f.patch, HBASE-8534-trunk.patch
>
>
> fix coverage org.apache.hadoop.hbase.mapreduce
> patch HBASE-8534-0.94.patch for branch-0.94
> patch HBASE-8534-trunk.patch for branch-0.95 and trunk

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira

Mime
View raw message