hbase-issues mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "samar (JIRA)" <j...@apache.org>
Subject [jira] [Commented] (HBASE-8518) Get rid of hbase.hstore.compaction.complete setting
Date Fri, 17 May 2013 09:15:16 GMT

    [ https://issues.apache.org/jira/browse/HBASE-8518?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13660509#comment-13660509
] 

samar commented on HBASE-8518:
------------------------------

the test testRecoveredEditsReplayCompaction is centered around the hbase.hstore.compaction.complete
setting.
First it sets it so that compaction happens.. then it manually tries to complete the compaction
by moving the files from the tmp and writeCompactionWalRecord. As the variable would be gone
there would be no files in tmp, and compaction would have been written to wal.


with the "hbase.hstore.compaction.complete" gone would it still make sense the have the test.


The only way to still have it is we could not let the compaction complete happen. 
                
> Get rid of hbase.hstore.compaction.complete setting
> ---------------------------------------------------
>
>                 Key: HBASE-8518
>                 URL: https://issues.apache.org/jira/browse/HBASE-8518
>             Project: HBase
>          Issue Type: Improvement
>            Reporter: Sergey Shelukhin
>            Priority: Minor
>              Labels: noob
>         Attachments: HBASE-8518-1.patch
>
>
> hbase.hstore.compaction.complete is a strange setting that causes the finished compaction
to not complete (files are just left in tmp) in HStore. 
> It's used by one test.
> The setting with the same name is also used by CompactionTool, but that usage is semi-unrelated
and could probably be removed easily.

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira

Mime
View raw message