hbase-issues mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Sergey Shelukhin (JIRA)" <j...@apache.org>
Subject [jira] [Commented] (HBASE-8498) PB WAL reading is broken due to some partial reads
Date Thu, 09 May 2013 00:11:18 GMT

    [ https://issues.apache.org/jira/browse/HBASE-8498?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13652552#comment-13652552
] 

Sergey Shelukhin commented on HBASE-8498:
-----------------------------------------

bq. In reading the int, should we also use IOUtils.readFully? 
Not doing that currently to distinguish good eof (end of records?) from bad EOF.
bq. You chose the above approach because you don't want to use (instanceof FSDataInputStream)
?
It's more correct this way given InputStream javadoc - InputStream guarantees to read some
bytes, not the requested amount, so that could be true for any implementation.
                
> PB WAL reading is broken due to some partial reads
> --------------------------------------------------
>
>                 Key: HBASE-8498
>                 URL: https://issues.apache.org/jira/browse/HBASE-8498
>             Project: HBase
>          Issue Type: Bug
>            Reporter: Sergey Shelukhin
>            Assignee: Sergey Shelukhin
>            Priority: Critical
>         Attachments: HBASE-8498-v0.patch, HBASE-8498-v0.patch, HBASE-8498-v1.patch, HBASE-8498-v2.patch
>
>
> From dev list, there's IOException during log splitting on hadoop-2.0.3. We need to understand
whether this is caused by EOF, and ignore it if it is.

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira

Mime
View raw message