hbase-issues mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Himanshu Vashishtha (JIRA)" <j...@apache.org>
Subject [jira] [Updated] (HBASE-8497) Protobuf WAL also needs a trailer
Date Mon, 20 May 2013 22:11:16 GMT

     [ https://issues.apache.org/jira/browse/HBASE-8497?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]

Himanshu Vashishtha updated HBASE-8497:
---------------------------------------

    Attachment: HBASE-8497-v5.patch

I did the following changes in this patch:
1) Renamed WALTrailerOffset to lastPositionToRead (as I commented on the rb). This is the
last byte position of WALEdits, so, the next() method should read up to this point.
2) Make the maximum trailer size configurable. To *avoid any surprise* for user, if the trailer
size > configured_max_allow_size, a WARN message is printed in the log, but the trailer
is respected (it is written/read). 
3) Incorporated the style nits suggested by jon.

mvn test TestHLog* pass.
                
> Protobuf WAL also needs a trailer 
> ----------------------------------
>
>                 Key: HBASE-8497
>                 URL: https://issues.apache.org/jira/browse/HBASE-8497
>             Project: HBase
>          Issue Type: Sub-task
>          Components: Protobufs, wal
>    Affects Versions: 0.95.1
>            Reporter: Enis Soztutar
>            Assignee: Himanshu Vashishtha
>             Fix For: 0.98.0, 0.95.1
>
>         Attachments: HBASE-8497-v0.patch, HBASE-8497-v2.patch, HBASE-8497-v3.patch, HBASE-8497-v4.patch,
HBASE-8497-v5.patch
>
>
> New Protobuf WAL has a header, but we will probably need a trailer as well, reserved
for later usage. 
> Right now, we can we just serialize an empty trailer, but putting more metadata there,
like range of sequence_id's, region names, table names etc might be needed in the future.


--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira

Mime
View raw message