hbase-issues mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Himanshu Vashishtha (JIRA)" <j...@apache.org>
Subject [jira] [Commented] (HBASE-8497) Protobuf WAL also needs a trailer
Date Thu, 23 May 2013 18:09:24 GMT

    [ https://issues.apache.org/jira/browse/HBASE-8497?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13665436#comment-13665436
] 

Himanshu Vashishtha commented on HBASE-8497:
--------------------------------------------

Oh I messed up with numbers:) 


{code}
2013-05-22 17:11:23,400 DEBUG wal.ProtobufLogReader (ProtobufLogReader.java:initInternal(118))
- After reading the trailer: lastPositionToRead: 372, fileLength: 380, trailerPresent: true
{code}
So, it should read: 
Note, magic is 4 bytes [377-380], trailer size is 4 bytes [373-376]. The trailer size is 0;
so last byte of the WALEdit is at 372, and lastPositionToRead is pointing to 372 only.

Also note the lastPositionToRead variable is changed to walEditsStopOffset, but that's a different
point.
                
> Protobuf WAL also needs a trailer 
> ----------------------------------
>
>                 Key: HBASE-8497
>                 URL: https://issues.apache.org/jira/browse/HBASE-8497
>             Project: HBase
>          Issue Type: Sub-task
>          Components: Protobufs, wal
>    Affects Versions: 0.95.1
>            Reporter: Enis Soztutar
>            Assignee: Himanshu Vashishtha
>             Fix For: 0.98.0, 0.95.1
>
>         Attachments: HBASE-8497-v0.patch, HBASE-8497-v2.patch, HBASE-8497-v3.patch, HBASE-8497-v4.patch,
HBASE-8497-v5.patch
>
>
> New Protobuf WAL has a header, but we will probably need a trailer as well, reserved
for later usage. 
> Right now, we can we just serialize an empty trailer, but putting more metadata there,
like range of sequence_id's, region names, table names etc might be needed in the future.


--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira

Mime
View raw message